Repository navigation
refactor(notifications): read alert settings with useEffectEvent - #3595
Merged
Merged
Conversation
Move sound and native alert emission into an Effect Event so the notification diff only re-runs when notifications change, while the next alert still reads the latest volume and visibility settings.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the sound and native-notification emission in
useNotificationEffectsinto a React 19useEffectEvent.playSound,showNotifications, ornotificationVolume.Verification
pnpm checkpnpm test— 2094 passed (includes a test that changes volume/show-notifications, refetches, and asserts the next alert uses the new values)pnpm buildContext
This extracts the
useEffectEventportion of the closed03-adopt-react-19-3-navigationwork. It is independent of the data-router migration in #3593.