Repository navigation
feat(renderer): add route and app error boundaries - #3594
Merged
Merged
Conversation
setchy
marked this pull request as ready for review
November 1, 2026 20:26
Render a route error element at the root and protected layout using Oops with a reload action, log router errors through RouterProvider onError, and wrap App in a last-resort class boundary for provider and bootstrap failures.
Replace the generic extraActions slot with a typed recovery action on Oops, and share the reload label, icon, and behavior through a ReloadButton primitive.
setchy
force-pushed
the
feat/renderer-error-boundaries
branch
from
November 1, 2026 20:28
242fadd to
33b6c0b
Compare
Screenshot the route error fallback inside the shell and the app-level fallback without chrome across the four theme variants.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Adds error handling around the data router introduced in #3593.
RouteErrorfallback that reusesOopswith a typed recovery action and a sharedReloadButton.errorElementon the root route (full-window fallback) and onProtectedLayout(keeps the sidebar and shell for screen-level errors).RouterProvider onErrorso render errors are reported once, without a re-render.<App />in a last-resortAppErrorBoundaryfor provider or bootstrap failures outside the route tree.recoveryaction.Verification
pnpm checkpnpm test— 2093 passedpnpm test:visual— 184 passed in the pinned Linux containerpnpm buildNotes
Oopsstill handles known domain errors (offline, credentials, scopes).Oops, not part of the declarativeGitifyErrorActionroute model.