Repository navigation
fix: only fill in session tokens for known Coder IDE links - #275
Merged
Merged
Conversation
ethanndickson
force-pushed
the
fix/trusted-app-links
branch
from
October 29, 2026 06:10
7149363 to
1da7912
Compare
ethanndickson
force-pushed
the
fix/trusted-app-links
branch
2 times, most recently
from
October 29, 2026 06:19
ca9fce8 to
c05762f
Compare
ethanndickson
force-pushed
the
fix/xcode-27
branch
from
October 29, 2026 06:19
bc2d535 to
084d422
Compare
ethanndickson
left a comment
Member
There was a problem hiding this comment.
A few comments inline.
Generated by an agent on behalf of the user
Member
|
I can move this out of the stack before merging btw, so dw about those prs blocking this |
ethanndickson
force-pushed
the
fix/trusted-app-links
branch
from
October 30, 2026 01:33
8396614 to
3ff66f1
Compare
ethanndickson
force-pushed
the
fix/xcode-27
branch
from
October 30, 2026 01:33
084d422 to
27a0095
Compare
Member
|
??????????
|
EhabY
added a commit
that referenced
this pull request
Oct 30, 2026
External app links now follow the same $SESSION_TOKEN rules as the dashboard (coder/coder#31208). - Fill in the token only when the link opens a known Coder IDE handler, its `url` param is the sign-in URL or the deployment's `dashboard_url`, and the placeholder is the `token` value. - Strip the placeholder from dev container (sub-agent) apps, matching coderd since coder/coder#31262. - Show links that need a token but don't match as disabled, with a tooltip explaining why. - Ask for confirmation before opening links outside the known IDE handlers. "Don't ask again" is remembered per scheme in UserDefaults. - Percent-encode the host and directory in VS Code links. - SDK: read `parent_id` from the workspace agent and `dashboard_url` from build info. Originally reviewed in #275
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External app links now follow the same
$SESSION_TOKENrules as the dashboard (coder/coder#31208).urlparam is the sign-in URL or the deployment'sdashboard_urlfrom build info, and the placeholder is thetokenvalue.parent_idfrom the workspace agent anddashboard_urlfrom build info.Decision log
dashboard_urlkept in memory, not saved: an admin can change the access URL, so it's fetched again on each launch and sign-in.NSAlertfor the confirmation: same as the RDP prompt andInvalidAgents, since.alertdoesn't work well from the menu bar.URL(string:)percent-encodes non-ASCII, and Swift compares strings by grapheme, so&or=followed by a combining mark would otherwise not split.Tests: CI fmt, lint and test pass. The menu UI and the confirmation alert weren't run by hand.