Repository navigation
fix: only fill in session tokens for known Coder IDE links - #283
Merged
Merged
Conversation
ethanndickson
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External app links now follow the same
$SESSION_TOKENrules as the dashboard (coder/coder#31208).urlparam is the sign-in URL or the deployment'sdashboard_urlfrom build info, and the placeholder is thetokenvalue.parent_idfrom the workspace agent anddashboard_urlfrom build info.Decision log
dashboard_urlkept in memory, not saved: an admin can change the access URL, so it's fetched again on each launch and sign-in.NSAlertfor the confirmation: same as the RDP prompt andInvalidAgents, since.alertdoesn't work well from the menu bar.URL(string:)percent-encodes non-ASCII, and Swift compares strings by grapheme, so&or=followed by a combining mark would otherwise not split.Same commits as #275, which merged into
fix/xcode-27. That branch was later rewritten and no longer contains them. They sit directly onmain, so this PR is #275's diff againstmain.Tests: the menu UI and the confirmation alert weren't run by hand.