Skip to content

feat(web): migrate admin surface off bespoke CSS (migration phase 3, surface 3) - #791

Merged
Zach Dunn (zachdunn) merged 1 commit into
mainfrom
feat/shadcn-phase-3-admin
Aug 23, 2026
Merged

feat(web): migrate admin surface off bespoke CSS (migration phase 3, surface 3)#791
Zach Dunn (zachdunn) merged 1 commit into
mainfrom
feat/shadcn-phase-3-admin

Conversation

@zachdunn

Copy link
Copy Markdown
Member

Third phase-3 surface of the Tailwind + shadcn migration (follows #787/#789; plan in .context/2026-08-22-tailwind-shadcn-migration-plan.md, local doc).

What

  • All six admin pages (workspaces, users, email, metrics, oauth, oauth/[clientId]) — static templates and script-generated HTML — moved to Tailwind utilities; legacy class names stay as DOM hooks.
  • New shared class-string constants in admin-ui.ts (table cells, buttons, mini-lists) keep the repeated chrome DRY across pages.
  • Admin CSS cut 889 → 200 lines (78%). What remains is deliberately state-driven or non-static: [data-state] status colors, JS-toggled .is-open rules, the 680px column collapse, the inline-SVG metrics chart styling, and the oauth-scopes fieldset.
  • Cascade rule from feat(web): migrate workspace settings pages off bespoke CSS (migration phase 3, surface 2) #789 applied: the narrow selects governed by kept ul-select (width:100%, unlayered) use inline style="width:auto" rather than a utility that would silently lose.

Verification

  • astro build, lint, admin-ui vitest 3/3 green.
  • Visual audit against the local stack with an admin session: workspaces table + full expand panel (members/plan/limits/storage forms), metrics tiles + range chips (pressed state still violet-filled) + bar chart, users table with search, oauth table + new-app form + scopes fieldset, email previews table — all at parity with pre-migration baselines.
  • Flagged for a prod glance: row-hover tint is bg-panel/55 replacing a color-mix() (visually close, not bit-identical), and the expand panel's nested list spacing is authored per-list now.

Screenshots attach via the managed comment.

…surface 3)

Re-plumbs /admin/* (workspaces, users, email, metrics, oauth + oauth detail) onto Tailwind utilities via shared class-string constants in admin-ui.ts (ADMIN_TH/ADMIN_TD/ADMIN_BTN/etc). Legacy class names stay in markup as hooks. admin.css/admin-workspaces.css/admin-metrics.css/admin-oauth.css reduced from 889 to 200 lines, keeping only data-state colors, JS-toggled .is-open/:empty structural rules, the responsive column collapse, and the metrics inline-SVG chart (interactive hover/tooltip).
@changeset-bot

changeset-bot Bot commented Aug 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 01a63cd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@uploads-sh

uploads-sh Bot commented Aug 23, 2026

Copy link
Copy Markdown

127.0.0.1-admin-after.webp
/account/workspaces/dev-demo/people · after

127.0.0.1-admin-metrics-after.webp
/account/workspaces/dev-demo/people · after

127.0.0.1-admin-oauth-after.webp
/account/workspaces/dev-demo/people · after

Maintained by uploads.sh · add media: uploads put <file> --pr 791 · docs

@zachdunn
Zach Dunn (zachdunn) merged commit 07d6b20 into main Aug 23, 2026
2 of 3 checks passed
@zachdunn
Zach Dunn (zachdunn) deleted the feat/shadcn-phase-3-admin branch August 23, 2026 01:08
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (2)
  • coderabbit:review
  • review
🚫 Excluded labels (none allowed) (1)
  • wip

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 30ee1b36-2ea4-4804-b3b6-db82120ea2ae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant