feat(web,ui): migrate files table and FileBrowser off bespoke CSS (phase 3, surface 5) - #794
Conversation
…se 3, surface 5) Converts the WorkspaceFileTable-exclusive wft-* rules in account-content.css to Tailwind utilities directly on the component's markup; legacy class names stay as DOM/test hooks. wft-* rules still needed by workspace-ui.ts's (dead but still-tested) placeholder builder or by ScreenshotsByPath.tsx/IslandErrorBoundary.tsx (wft-status-block, wft-error, wft-filter*, wft-suggest*, wft-sectionhead*, wft-view__btn, wft-grid, wft-row/wft-head*, wft-name, wft-size, wft-type, wft-vis, and the 560px row/head responsive collapse) are left as CSS per the cascade rule — those competitors are not deleted, so converting their markup would just be overridden. Converted and deleted from CSS: .wft root, .wft-view, chips/clearall, banner, thumb/filename, vis modifiers, the file-actions menu (trigger/popover/items/two-step delete confirm), the grid-view card family, and load-more.
…face 5) FileBrowser is exported from @uploads/ui but currently unreferenced by any app (grepped repo-wide) — the ul-files-* rules it owned are its sole consumer, so they're safe to delete outright rather than reduce. Converts the crumbs/list/row/icon/name/state/spin markup to Tailwind utilities (animate-spin + motion-reduce:animate-none replaces the ul-files-spin keyframes); no change to onSelect/navigation behavior.
|
|
Maintained by uploads.sh · add media: |
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Phase 3, surface 5 (final): migrates the files-table surface and the
FileBrowserdesign-system component off bespoke CSS onto Tailwind utilities.What changed
WorkspaceFileTable.tsx: converted to Tailwind utilities and deleted the corresponding rules fromaccount-content.css— root grid, view container, filter chips, PR-match banner, thumb/filename, visibility modifiers, the⋯action menu (trigger, popover, items, two-step delete confirm), the grid-view card family, and load-more.workspace-ui.ts's tested placeholder builder and/or other components, per the cascade rule): filter bar/suggestions, section head, view-toggle buttons, crumbs, row/head grid layout, and the 560px responsive collapse.FileBrowser.tsx(packages/ui): confirmed by repo-wide grep it has no external consumers; migrated fully and deleted the wholeul-filesblock fromstyles.css(custom spinner keyframes replaced withanimate-spin motion-reduce:animate-none). Link/anchor behavior untouched./f/page) is restyled only.Verification
pnpm --filter @uploads/ui build,astro build, oxlint/oxfmt clean; 54/54 tests pass.⋯menu, delete-confirm armed state (dismissed), grid view, and the 560px column collapse all render at parity.Closes out phase 3 of the Tailwind/shadcn migration (previous surfaces: #787, #789, #791, #793).