Skip to content

feat(web): migrate screenshots-by-path surface off bespoke CSS (migration phase 3, surface 4) - #793

Merged
Zach Dunn (zachdunn) merged 2 commits into
mainfrom
feat/shadcn-phase-3-screenshots
Aug 23, 2026
Merged

feat(web): migrate screenshots-by-path surface off bespoke CSS (migration phase 3, surface 4)#793
Zach Dunn (zachdunn) merged 2 commits into
mainfrom
feat/shadcn-phase-3-screenshots

Conversation

@zachdunn

Copy link
Copy Markdown
Member

Fourth phase-3 surface (follows #787/#789/#791; plan in .context/2026-08-22-tailwind-shadcn-migration-plan.md, local doc).

What

  • ScreenshotsByPath.tsx + screenshots.astro: the .wsp* families (project/group/drill layout, grid, filter + suggestions, segmented toggle, empty states, skeletons) moved to Tailwind utilities; legacy class names stay as DOM hooks. The .wsp-project + .wsp-project hairline became an index-based bordered prop (React map output has no sibling selector); hover/focus disclosure uses group-hover:/group-focus-visible:; @media (hover:none) via arbitrary variant.
  • Deliberately kept as CSS: tile/thumb aspect-ratio chrome (driven by JS-set --wsp-ar/--wsp-strip-h custom properties) and the entire flip-aware hover-preview block (fix(web): flip-aware hover-preview placement + keyboard focus parity #776) — placement logic and its CSS untouched.
  • Shared rules (ws-empty-state, ws-skel, wft-*) untouched — they serve other surfaces.

Verification

  • astro build, lint green; screenshots vitest suites 49/49 (includes the fix(web): flip-aware hover-preview placement + keyboard focus parity #776 placement tests).
  • Visual audit against the local stack with a signed-in session on the migrated DOM: layout, filter bar, mode pills, group rhythm all at parity — including one regression caught and fixed in audit (the root .wsp grid/32px-gap rule was deleted without its replacement utilities, collapsing between-project spacing).
  • Hover-preview could not be exercised locally (fixture thumbnails are broken images without cdn-cgi transforms; the preview never mounts) — logic is untouched and unit-tested, but worth a prod hover after merge.

Screenshot attaches via the managed comment.

…tion phase 3, surface 4)

Converts the wsp-* structural/typography rules in account-content.css to
Tailwind utilities directly on ScreenshotsByPath.tsx markup; legacy class
names stay as DOM/test hooks. Kept as CSS: the custom-property-driven
thumb/strip sizing (JS-set --wsp-ar aspect ratio, --wsp-strip-h) and the
flip-aware hover-preview popover chrome (#776) — both are subtle, JS-coupled
layout left alone per the migration plan's risk guidance.

- .wsp/.wsp-project/.wsp-group/.wsp-drill*/.wsp-grid/.wsp-filter*/
  .wsp-suggest*/.wsp-toggle*/.wsp-state/.wsp-pair -> Tailwind utilities,
  deleted from account-content.css.
- Sibling-selector .wsp-project + .wsp-project (border between project
  sections) replaced with an index>0 bordered prop, since React map output
  has no adjacent-sibling CSS selector to hook.
- :hover/:focus-visible view-all disclosure replaced with group/group-hover/
  group-focus-visible; @media(hover:none) replaced with the matching
  Tailwind arbitrary variant.
- No client:* directive changes; manual hydrateRoot mount in
  screenshots.astro untouched.
The root .wsp rule (display:grid; gap:32px) was deleted with the rest of
the family but the element never received the replacement utilities, which
collapsed the between-project rhythm.
@changeset-bot

changeset-bot Bot commented Aug 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2e26666

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@uploads-sh

uploads-sh Bot commented Aug 23, 2026

Copy link
Copy Markdown

127.0.0.1-account-workspaces-dev-demo-screenshots-after.webp
/account/workspaces/dev-demo/screenshots · after

Maintained by uploads.sh · add media: uploads put <file> --pr 793 · docs

@zachdunn
Zach Dunn (zachdunn) merged commit 878f3db into main Aug 23, 2026
2 of 3 checks passed
@zachdunn
Zach Dunn (zachdunn) deleted the feat/shadcn-phase-3-screenshots branch August 23, 2026 01:19
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (2)
  • coderabbit:review
  • review
🚫 Excluded labels (none allowed) (1)
  • wip

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a2d8556a-001a-45fa-9bef-9b7548c8d0a4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant