Repository navigation
CAMEL-25645: camel-milo - upgrade guide notes for 4.22.3 and 4.18.6 - #28055
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 0 of 706 tested, 0 compile-only — current: 0 all testedMaveniverse Scalpel detected 0 affected modules (current approach: 0). Skip-tests mode would test 0 modules (1 direct + 0 downstream), skip tests for 0 (generated code, meta-modules) Modules Scalpel would test (0)
|
davsclaus
left a comment
There was a problem hiding this comment.
Thanks @oscerd. I checked the note against the backports. Both copies match the 4.24 entry word for word. The trust-list, certificateValidator and trustAllCertificates behaviour, and the log and exception messages it quotes, are the same in #28053 (camel-4.22.x) and #28054 (camel-4.18.x). The differences from main are only branch context: the cache id, the security = "insecure:ssl" attribute that @UriParam lacks on 4.18.x, and the main-only SecurityUtils owner map. None of them changes what the note describes.
The placement is right. The fix is not in the camel-4.22.2 tag, so it goes in a new "Upgrading from 4.22.2 to 4.22.3" section, and on 4.18 it sits in the 4.18.6 section. The AsciiDoc follows the surrounding headings. The earlier camel-milo - potential breaking change entry in the 4.18 guide is about the CamelMiloAwait header, so nothing is duplicated.
Two merge-order points, neither blocking:
- Merge this after #28053 and #28054, so the guide does not announce a change for a release that misses it.
- #28052 adds the same 4.22.3 heading at the same place (details inline).
Claude Code on behalf of Claus Ibsen
|
@oscerd #28052 is merged, so this now conflicts on the Claude Code on behalf of Claus Ibsen |
The OPC UA client validates the server certificate on the camel-4.22.x and camel-4.18.x branches too. The 4.22.2 release was already cut when the change was backported, so its note goes into the section for 4.22.3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
1c275b1 to
8332b5d
Compare
davsclaus
left a comment
There was a problem hiding this comment.
The rebase fixes the heading conflict: there is now a single == Upgrading from 4.22.2 to 4.22.3 with the milo note first and the elasticsearch/opensearch notes from #28052 unchanged, and the 4.18 note sits inside Upgrading from 4.18.5 to 4.18.6. The text matches the 4.24 note from #27824, and the options and log messages it names (trustListDirectory, certificateValidator, trustAllCertificates, the two WARN messages) exist on camel-4.22.x and camel-4.18.x after #28053/#28054. Merges cleanly with main and with #28078 in either order.
Claude Code on behalf of Claus Ibsen. This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Summary
CAMEL-25645
Upgrade guide notes for the backports of #27824, which are merged:
camel-4x-upgrade-guide-4_22.adoc: the note goes in "Upgrading from 4.22.2 to 4.22.3", before the elasticsearch and opensearch notes that CAMEL-25706, CAMEL-25707, CAMEL-25708: upgrade guide notes for the 4.22.3 and 4.18.6 backports #28052 added under the same heading. 4.22.2 was already tagged when the change was backported ([backport camel-4.22.x] CAMEL-25645: camel-milo - let the OPC UA client validate the server certificate against a trust list #28053).camel-4x-upgrade-guide-4_18.adoc: the note goes in "Upgrading from 4.18.5 to 4.18.6", between the camel-smpp and camel-pqc notes ([backport camel-4.18.x] CAMEL-25645: camel-milo - let the OPC UA client validate the server certificate against a trust list #28054).The text is the same as the 4.24 note added by #27824, since the behaviour is the same on these branches. Documentation only. Rebased onto main after #28052, keeping a single 4.22.3 heading.
Claude Code on behalf of Andrea Cosentino
🤖 Generated with Claude Code