Repository navigation
CAMEL-25585: upgrade guide - camel-chunk notes for 4.22.2 and 4.18.6 - #27950
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet-bot
left a comment
There was a problem hiding this comment.
LGTM. The upgrade guide notes for 4.22.2 and 4.18.6 are accurate — wording is identical to the 4.24 entry, placement after the camel-mustache, camel-chunk header renaming section is correct, and both backport PRs are referenced in the description.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 0 of 706 tested, 0 compile-only — current: 0 all testedMaveniverse Scalpel detected 0 affected modules (current approach: 0). Skip-tests mode would test 0 modules (1 direct + 0 downstream), skip tests for 0 (generated code, meta-modules) Modules Scalpel would test (0)
|
davsclaus
left a comment
There was a problem hiding this comment.
Thanks @oscerd for syncing the camel-chunk note to the maintenance guides on main. The 4.22 entry is in the right place, under "Upgrading from 4.22.1 to 4.22.2", and both copies match the 4.24 entry.
One placement fix, inline: in camel-4x-upgrade-guide-4_18.adoc the entry landed at the end of the "Upgrading from 4.18.4 to 4.18.5" section, next to the CAMEL-24895 header-rename note. 4.18.5 is already released, and the backport (bb60b1d, #27873) ships in 4.18.6, so it belongs under "Upgrading from 4.18.5 to 4.18.6" at the top of the file.
Claude Code on behalf of Claus Ibsen
The CAMEL-25585 camel-chunk fix (render message data containing Chunk tags literally) was backported to camel-4.22.x (4.22.2, apache#27868) and camel-4.18.x (4.18.6, apache#27873). Add the matching upgrade-guide notes to the 4_22 and 4_18 guides on main, mirroring the 4_24 note, since the upgrade guides for all release lines live on main. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
5e77613 to
b91ef1a
Compare
davsclaus
left a comment
There was a problem hiding this comment.
Thanks @oscerd. The placement point from my earlier review is fixed: in camel-4x-upgrade-guide-4_18.adoc the camel-chunk note now sits under "Upgrading from 4.18.5 to 4.18.6", which matches the backport (bb60b1d, #27873), merged after the camel-4.18.5 tag. The 4.22 note stays under "Upgrading from 4.22.1 to 4.22.2", and that is right: the 4.22.x backport (b4e0364, #27868) is in the camel-4.22.2 tag.
Both copies match the 4.24 entry word for word. The Java changes in both backports are identical to the main commit 6fdf569, so the same text holds on each line. There is no other camel-chunk rendering note in either file, and the PR merges cleanly with #28052 and #28055. Good to merge.
Claude Code on behalf of Claus Ibsen
Documentation follow-up for CAMEL-25585 (camel-chunk renders message data containing Chunk tags literally).
The fix merged on
main(#27721, 4.24.0) and was backported tocamel-4.22.x(#27868, 4.22.2) andcamel-4.18.x(#27873, 4.18.6). Since the upgrade guides for all release lines live onmain, this adds the matchingcamel-chunknote tocamel-4x-upgrade-guide-4_22.adocandcamel-4x-upgrade-guide-4_18.adoc(same wording as the 4.24 note, inserted next to the existingcamel-mustache, camel-chunksection).Docs only — no code change.
JIRA: https://issues.apache.org/jira/browse/CAMEL-25585
🤖 Generated with Claude Code