Repository navigation
CAMEL-25706, CAMEL-25707, CAMEL-25708: upgrade guide notes for the 4.22.3 and 4.18.6 backports - #28052
Conversation
…22.3 and 4.18.6 backports The credentials of camel-elasticsearch, camel-elasticsearch-rest-client and camel-opensearch are now bound to the cluster nodes on camel-4.22.x and camel-4.18.x as well. Add the matching notes to the 4.22 guide, in a new 4.22.2 to 4.22.3 section since 4.22.2 has already been cut, and to the 4.18.6 section of the 4.18 guide. camel-4.18.x has no openSearchClient option, so the 4.18 note only names the client option. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet-bot
left a comment
There was a problem hiding this comment.
LGTM. All option names verified against component source on both camel-4.22.x and camel-4.18.x branches — hostAddresses (camel-elasticsearch, camel-opensearch), hostAddressesList (camel-elasticsearch-rest-client), restClient, client/openSearchClient — all correct. The 4.18 guide correctly omits openSearchClient since that option doesn't exist on that branch. Placement and ordering are correct.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 0 of 706 tested, 0 compile-only — current: 0 all testedMaveniverse Scalpel detected 0 affected modules (current approach: 0). Skip-tests mode would test 0 modules (1 direct + 0 downstream), skip tests for 0 (generated code, meta-modules) Modules Scalpel would test (0)
|
davsclaus
left a comment
There was a problem hiding this comment.
Thanks @oscerd. I checked the notes against the backports. #28050 (camel-4.22.x) has the same code changes as the main commits 442e440, f8bd57d and 0048096. #28051 (camel-4.18.x) differs only in the indentation and context of the older producer code. The option names are right on each branch: hostAddresses for elasticsearch and opensearch, hostAddressesList and restClient for elasticsearch-rest-client, and client for opensearch. openSearchClient exists on 4.22.x but not on 4.18.x, so dropping it from the 4.18 note is correct. The 4.18 opensearch code being replaced is the match-all AuthScope that sent the credentials to every node, so "Every node of a multi-host cluster still receives them" holds there too.
The placement is right. camel-4.22.2 is tagged without these fixes, and camel-4.18.5 is released, so the notes belong in 4.22.3 and 4.18.6. The text matches the 4.24 entries, and neither file has an earlier entry on this.
Two merge-order points, neither blocking:
- As the description says, merge this after #28050 and #28051.
- #28055 adds the same
== Upgrading from 4.22.2 to 4.22.3heading at the same line ofcamel-4x-upgrade-guide-4_22.adoc.git merge-treereports a conflict there, so whichever PR merges second needs a rebase that keeps a single 4.22.3 heading over both sets of notes.
Claude Code on behalf of Claus Ibsen
Description
The upgrade-guide notes for the camel-4.22.x and camel-4.18.x backports of CAMEL-25706, CAMEL-25707 and CAMEL-25708 (#28050, #28051). They go on main, where all the guides live.
openSearchClientoption, so the camel-opensearch note only names theclientoption.This should be merged after the two backports, so that the notes cannot land for a release that misses the fix.
Documentation only.
Claude Code on behalf of oscerd
🤖 Generated with Claude Code