Repository navigation
refactor(oidc): follow the module layout (moves only) - #841
Merged
Merged
Conversation
constants, settings, presets, state and runtime move to oidc/core/; the
provider, client, discovery, renewal, directory, cache persistence,
token encryption and JWKS to oidc/identity/; endpoints to oidc/web/.
Tests mirror the areas. oidc.{settings,provider,jwks} stay as deprecated
aliases until 0.0.46. The layout doc and root test also list
task_config.py, which background_tasks imports by name.
Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying simple-module-python with
|
| Latest commit: |
139a0c4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e339d9f4.simple-module-python.pages.dev |
| Branch Preview URL: | https://refactor-layout-oidc.simple-module-python.pages.dev |
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves-only restructure of the
oidcmodule todocs/module-layout.md, same pattern as #838 (keycloak).oidc/core/: constants, settings, presets, state, runtimeoidc/identity/(DOMAIN_AREAS): provider, client, discovery, renewal, directory, persistence, tokens, jwksoidc/web/endpoints/: api, viewsoidc.settings,oidc.provider,oidc.jwksstay as deprecatedsys.modulesaliases (remove_in0.0.46).modules/auth/tests(including the dynamicimport_module(f"{provider}.identity.tokens")in conftest),modules/keycloak/tests,modules/users/tests/test_users_login_deep_link.py.task_config.py(imported by name inbackground_tasks/task_routing.py) added to the allowed package-root set and the layout doc.No logic changes: renamed files differ only in import lines.
Verification
make lint,make ci-docs-build,make doctor(0 errors, 0 warnings): greenmake test-py: 7875 passed, 45 skipped;make test-js: green-W error::DeprecationWarningimport of the new paths: okhttps://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq