Repository navigation
refactor(api_tokens): follow the module layout (moves only) - #845
Merged
Merged
Conversation
constants, settings, services and the cleanup hooks move to
api_tokens/core/; the token format (tokens.py, now credentials/format.py),
scopes, owner, service, resolver and audit naming to
api_tokens/credentials/; deps and endpoints to api_tokens/web/; the page
components and types to ui/. Tests mirror the areas.
api_tokens.{constants,service,resolver,tokens} stay as deprecated aliases
until 0.0.46.
Claude-Session: https://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq
Deploying simple-module-python with
|
| Latest commit: |
ec151a2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4bd5e996.simple-module-python.pages.dev |
| Branch Preview URL: | https://refactor-layout-api-tokens.simple-module-python.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
api_tokenstodocs/module-layout.md(same pattern as refactor(keycloak): follow the module layout (moves only) #838 keycloak and refactor(oidc): follow the module layout (moves only) #841 oidc):constants/settings/services/tenant_cleanup/user_cleanupgo tocore/;tokens.pybecomescredentials/format.pyandscopes/owner/service/resolver/auditgo tocredentials/(added toDOMAIN_AREAS);depsandendpointsgo toweb/; page components andtypes.tsgo toui/(pages/api.tsandapi.generated.tsstay); tests mirror the areas.api_tokens.{constants,service,resolver,tokens}stay as deprecatedsys.modulesaliases (remove_in0.0.46).api_tokens.tenant_cleanup.purge_tenant_data,api_tokens.user_cleanup.purge_user_tokens), as fix(feature_flags,sharing): keep durable handler names stable across the layout move #843 did for feature_flags/sharing;host/tests/test_durable_wire_names.pychecks them.api_tokens.credentials.resolver(same as the other layout moves).Verification
make lint,make doctor(0 errors),ci-api-types-fresh,ci-i18n-fresh,ci-css-build,ci-docs-build,make test-py(7876 passed, 45 skipped),make test-jsall green.api_tokens.tokens is api_tokens.credentials.format) and-W error::DeprecationWarningimport of the module, resolver and API endpoints pass.Test plan
/api-tokens/and/admin/api-tokens/, create a token, confirm the created-token dialoghttps://claude.ai/code/session_01FXHA3ZicrtZ4C5QPEgxfgq