Repository navigation
Conversation
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gen2 presentation mods cannot load the shared native menu-chrome contract, so they decline the entire picture-hook installation even when battle data and picture operations exist.
Port the actual Gen2 tile-grid menu renderer: paper/frames, palette-aware glyphs and cursors, wrapping, numeric/balance fields, clipped panels and cursor lists. It uses this engine's existing Font, PaletteFX and input objects, including negative Unicode glyph codes and framebuffer DPI. Palette inversion is resolved before the native shade register; no second palette mode, HP clock or battle controller is introduced. The public Gen2 module spelling resolves to this actual implementation.
Validation: 116 checks pass in composition and independently; unchanged main fails because the module is absent. Tests cover native palette/register order, font/frame output, actual input selection/cancel/disabled rows, scrolling, DPI and graphics restoration. Combined with #223, the unchanged ASC OMEGA 1.7 package installs its real picture hooks and displays the actual Pokemon and HUDs in imported Crystal on OpenGL/VSync 0 and Metal/VSync 1. First/Third field entries, actual damage/HP drain, native party switching, RUN and presented world return pass on both backends. Native no-mod flows also pass.
The GPU-tested composition is
d6149206(263 engine suites, three SDK suites, B30). Windows/macOS packages have identical verified payloads and 1,031 source files. Windows hardware is untested. Full generated model rendering, battle text/move menus/animations and continuous movement remain open; this module does not claim to provide those. The corrected ASC OMEGA 1.8 package also passes the complete native damage/party-switch/RUN loop on both OpenGL and Metal with normal VSync; the changed flight sequence itself remains untested.