Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source GSC consumers read Pokemon maxHp/name/types and specialAttack/specialDefense, while the shared native engine stores stats.hp and spatk/spdef. Publish these names on the actual native records, with live native writes, stat replacement and registry edits; no duplicate HP counter, Pokemon or serialized helper fields. Preserve existing custom behavior and explicit raw fields, while protected owners can decline decoration. Strict SDK schemas accept native split-stat patches within1..255 integer bounds.
This adaptation uses this older host's actual Pokemon RNG constructor, BattleState.makeBattler and generic Loader registry fold. It does not fabricate the newer fork's Battler extraction, live source model, identity helpers or options constructor. The host has no semantic-checkpoint subsystem; that integration is separate fork work, not claimed here. The plain helper retains exact native-wrapper authentication and native-slot rebinding without traversing mod storage.
Independent frozen older-host tests on6985a377:184 data checks without LOVE,170 actual native birth/save/validation/combat/SDK/schema checks across15 registered editions, plus4454 frame-query,116 chrome and1031 position regressions. Initial c0ea73d failed the real SDK patch because the nested schema rejected spatk; the schema was corrected and the actual loader test rerun. No full older-host/GPU/unchanged-mod/final-release acceptance is claimed.
Stacked on #398 (screen position) and its #397/#383/#224 viewport/chrome prerequisites. No upstream merge is performed. The standalone source battle constructor/turn executor remains open. No mod, protected installation or player profile is edited.
Independently owned integration/tests by Roxas2712 are offered under https://github.com/Roxas2712/Gen2Recomped/blob/main/LICENSE-ROXAS2712.md, including the specific Cedric / UNDERdecoded permission with visible credit. Existing engine authors' rights, notices and earlier grants remain effective. See docs/native-gen2-mon-fields.md.