Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Gen2 menus have no source
screenPosoption or ScreenPosition owner. Add CENTER/UPPER/TOP through the existing native options, save and compositor paths. Use a shared whole-framebuffer-pixel lift, respect safe top insets, preserve skin/split ownership and grow the world canvas below a raised camera. Source Game2 frame queries and native chrome observe the same position. Default CENTER is preserved.This offer is stacked on #397 and contains its already-offered viewport/chrome prerequisites (#383 and #224). It adapts the actual older Renderer:endFrame and flat options menu: no newer frameRects or grouped-menu API is fabricated.
Independent selected qualification on
b83c8fa4: 1,031 screen-position checks including actual native final world/UI blits, eight editions, three positions, portrait/landscape/Retina fitting, safe insets, the real skin parser and normal menu input/save/boot application. Existing 4,454 frame-query and 116 chrome checks also pass. Managed test host cleaned after exit. Complete older-host suite, actual GPU/device/skin coverage and final release acceptance remain open. Details: docs/native-screen-position.md.The source helper is adapted from Gen1Recomp revision
535a5ec0, copyright BOIS CLUB GAMES, LLC, with its GPLv3/Section 7 terms retained in licenses/GEN1RECOMP-TOUCH-SKINS.md. The helper and native integration retain those terms and credits. Independently owned integration/tests by Roxas2712 are offered under https://github.com/Roxas2712/Gen2Recomped/blob/main/LICENSE-ROXAS2712.md, including the specific Cedric / UNDERdecoded permission with visible credit. Existing authors' rights and earlier grants remain effective. No mod or player installation is changed.