Skip to content

Switch deploy to the active-app-version classification#8056

Draft
isaacroldan wants to merge 1 commit into
deploy-split/05b-deploy-app-version-modulefrom
deploy-split/05c-switch-deploy
Draft

Switch deploy to the active-app-version classification#8056
isaacroldan wants to merge 1 commit into
deploy-split/05b-deploy-app-version-modulefrom
deploy-split/05c-switch-deploy

Conversation

@isaacroldan

@isaacroldan isaacroldan commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Part 7 of 8 — splitting #8040. The switch-over.

WHY are these changes introduced?

With the classification module in place (#8055), deploy can stop using the interactive matching flow.

WHAT is this pull request doing?

  • ensureDeployContext now calls ensureDeployIdentifiersFromAppVersion and returns DeployIdentifiers.
  • The bundle/upload path consumes the resulting maps; upload's extensionIds becomes appModuleRegistrationIds.
  • deploy no longer writes identifiers back to the .env file.

The interactive matching flow is now unused; it's removed in #8049.

⚠️ User-facing behavior change (deploy classification is non-interactive; identifiers are no longer persisted to .env) — needs a changeset.

How to test your changes?

pnpm --filter @shopify/app exec vitest run src/cli/services/deploy.test.ts src/cli/services/context.test.ts src/cli/services/deploy/upload.test.ts

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 10, 2026
@isaacroldan isaacroldan force-pushed the deploy-split/05b-deploy-app-version-module branch from adc37e4 to 838bb7e Compare July 10, 2026 11:28
@isaacroldan isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from d8abcc9 to 6819f61 Compare July 10, 2026 11:28
@isaacroldan isaacroldan force-pushed the deploy-split/05b-deploy-app-version-module branch from 838bb7e to 146fd63 Compare July 10, 2026 11:56
@isaacroldan isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from 6819f61 to 7a73d6c Compare July 10, 2026 11:56
@isaacroldan isaacroldan force-pushed the deploy-split/05b-deploy-app-version-module branch from 146fd63 to 9ce00c5 Compare July 10, 2026 12:06
@isaacroldan isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from 7a73d6c to 346a29f Compare July 10, 2026 12:06
@isaacroldan isaacroldan force-pushed the deploy-split/05b-deploy-app-version-module branch from 9ce00c5 to aefc40d Compare July 10, 2026 12:56
@isaacroldan isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from 346a29f to 3036c8c Compare July 10, 2026 12:56
@isaacroldan isaacroldan force-pushed the deploy-split/05b-deploy-app-version-module branch from aefc40d to 03fa20e Compare July 10, 2026 13:44
@isaacroldan isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from 3036c8c to 644c235 Compare July 10, 2026 13:45
@github-actions

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/object.d.ts
@@ -38,6 +38,14 @@ export declare function mapValues<T extends object, TResult>(source: T | null |
  * @returns True if the objects are equal, false otherwise.
  */
 export declare function deepCompare(one: object, two: object): boolean;
+/**
+ * Deeply compares two values and treats arrays as order-insensitive.
+ *
+ * @param one - The first value to be compared.
+ * @param two - The second value to be compared.
+ * @returns True if the normalized values are equal, false otherwise.
+ */
+export declare function deepCompareWithOrderInsensitiveArrays(one: unknown, two: unknown): boolean;
 /**
  * Return the difference between two nested objects.
  *

@isaacroldan isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from 644c235 to 3260c7b Compare July 10, 2026 14:54
@isaacroldan isaacroldan force-pushed the deploy-split/05b-deploy-app-version-module branch from 03fa20e to 2a3ef5e Compare July 10, 2026 14:54
Wires `deploy` to the new module: `ensureDeployContext` calls
`ensureDeployIdentifiersFromAppVersion` and returns `DeployIdentifiers`, the
bundle/upload path consumes the resulting maps (upload's `extensionIds`
becomes `appModuleRegistrationIds`), and `deploy` no longer writes identifiers
back to the .env file. The interactive matching flow is now unused; it is
removed in the next commit.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@isaacroldan isaacroldan force-pushed the deploy-split/05b-deploy-app-version-module branch from 2a3ef5e to 9cee8ca Compare July 10, 2026 15:54
@isaacroldan isaacroldan force-pushed the deploy-split/05c-switch-deploy branch from 3260c7b to c283e20 Compare July 10, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant