Switch deploy to the active-app-version classification#8056
Draft
isaacroldan wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 10, 2026
adc37e4 to
838bb7e
Compare
d8abcc9 to
6819f61
Compare
838bb7e to
146fd63
Compare
6819f61 to
7a73d6c
Compare
146fd63 to
9ce00c5
Compare
7a73d6c to
346a29f
Compare
9ce00c5 to
aefc40d
Compare
346a29f to
3036c8c
Compare
aefc40d to
03fa20e
Compare
3036c8c to
644c235
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/object.d.ts@@ -38,6 +38,14 @@ export declare function mapValues<T extends object, TResult>(source: T | null |
* @returns True if the objects are equal, false otherwise.
*/
export declare function deepCompare(one: object, two: object): boolean;
+/**
+ * Deeply compares two values and treats arrays as order-insensitive.
+ *
+ * @param one - The first value to be compared.
+ * @param two - The second value to be compared.
+ * @returns True if the normalized values are equal, false otherwise.
+ */
+export declare function deepCompareWithOrderInsensitiveArrays(one: unknown, two: unknown): boolean;
/**
* Return the difference between two nested objects.
*
|
644c235 to
3260c7b
Compare
03fa20e to
2a3ef5e
Compare
Wires `deploy` to the new module: `ensureDeployContext` calls `ensureDeployIdentifiersFromAppVersion` and returns `DeployIdentifiers`, the bundle/upload path consumes the resulting maps (upload's `extensionIds` becomes `appModuleRegistrationIds`), and `deploy` no longer writes identifiers back to the .env file. The interactive matching flow is now unused; it is removed in the next commit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2a3ef5e to
9cee8ca
Compare
3260c7b to
c283e20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
With the classification module in place (#8055),
deploycan stop using the interactive matching flow.WHAT is this pull request doing?
ensureDeployContextnow callsensureDeployIdentifiersFromAppVersionand returnsDeployIdentifiers.extensionIdsbecomesappModuleRegistrationIds.deployno longer writes identifiers back to the.envfile.The interactive matching flow is now unused; it's removed in #8049.
.env) — needs a changeset.How to test your changes?
pnpm --filter @shopify/app exec vitest run src/cli/services/deploy.test.ts src/cli/services/context.test.ts src/cli/services/deploy/upload.test.ts