Add active-app-version deploy classification module#8055
Draft
isaacroldan wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 10, 2026
7a1e052 to
7382b73
Compare
adc37e4 to
838bb7e
Compare
7382b73 to
ccf6b90
Compare
9ce00c5 to
aefc40d
Compare
680ecf7 to
156849c
Compare
Adds `deploy-app-version` (classify each local extension against the active version's modules — match by UID, legacy UUID fallback — into created/updated/deleted/unchanged) and `deploy-app-version-migrations` (run the supported legacy extension migrations first). Reshapes `getAppIdentifiers` and `EnsureDeploymentIdsPresenceOptions.envIdentifiers` to the flat UUID-by-local-identifier map the module consumes. The module is not wired into `deploy` yet — the switch is the next commit — so behavior is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
aefc40d to
03fa20e
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/object.d.ts@@ -38,6 +38,14 @@ export declare function mapValues<T extends object, TResult>(source: T | null |
* @returns True if the objects are equal, false otherwise.
*/
export declare function deepCompare(one: object, two: object): boolean;
+/**
+ * Deeply compares two values and treats arrays as order-insensitive.
+ *
+ * @param one - The first value to be compared.
+ * @param two - The second value to be compared.
+ * @returns True if the normalized values are equal, false otherwise.
+ */
+export declare function deepCompareWithOrderInsensitiveArrays(one: unknown, two: unknown): boolean;
/**
* Return the difference between two nested objects.
*
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
deploymatched local extensions to remote registrations through the interactive Partners-era flow. On App Management, modules are identified deterministically by UID, so the matching can be derived from the app's active version instead of prompting.WHAT is this pull request doing?
deploy-app-versionmodule: classifies each local extension against the active version's modules — match by UID, with a legacy UUID fallback for un-migrated extensions — into created / updated / deleted / unchanged.deploy-app-version-migrations: runs the supported legacy extension migrations before classifying.getAppIdentifiersandEnsureDeploymentIdsPresenceOptions.envIdentifiersto the flat UUID map the module consumes.The module is not wired into
deployyet (that's #8056), so behavior is unchanged. Covered by its own unit test.How to test your changes?
pnpm --filter @shopify/app exec vitest run src/cli/services/context/deploy-app-version.test.ts