Rework release config diff to compare version against active version#8054
Open
isaacroldan wants to merge 1 commit into
Open
Rework release config diff to compare version against active version#8054isaacroldan wants to merge 1 commit into
isaacroldan wants to merge 1 commit into
Conversation
This was referenced Jul 10, 2026
Contributor
Author
This was referenced Jul 10, 2026
7a1e052 to
7382b73
Compare
0e761f5 to
7f5da67
Compare
7382b73 to
ccf6b90
Compare
7f5da67 to
8e14666
Compare
ccf6b90 to
680ecf7
Compare
8e14666 to
d1ec8fa
Compare
680ecf7 to
156849c
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/object.d.ts@@ -38,6 +38,14 @@ export declare function mapValues<T extends object, TResult>(source: T | null |
* @returns True if the objects are equal, false otherwise.
*/
export declare function deepCompare(one: object, two: object): boolean;
+/**
+ * Deeply compares two values and treats arrays as order-insensitive.
+ *
+ * @param one - The first value to be compared.
+ * @param two - The second value to be compared.
+ * @returns True if the normalized values are equal, false otherwise.
+ */
+export declare function deepCompareWithOrderInsensitiveArrays(one: unknown, two: unknown): boolean;
/**
* Return the difference between two nested objects.
*
|
d1ec8fa to
fc1a187
Compare
156849c to
7f752f1
Compare
Base automatically changed from
deploy-split/04-deploy-identifiers-shape
to
main
July 10, 2026 15:51
Adds `buildConfigExtensionIdentifiersBreakdown` (a plain local-vs-remote field diff using order-insensitive array comparison) and `configExtensionsIdentifiersReleaseBreakdown`, and switches `release` to them: the config breakdown now compares the version being released against the app's active version instead of re-fetching remote configuration. Only affects the `release` command. The shared breakdown helper is reused by the deploy classification added next in the stack. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
7f752f1 to
0c2f2f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
Both
releaseand the newdeployclassification need to diff app configuration between two module sets. This introduces that shared primitive and adopts it inrelease, independently of thedeploychange.WHAT is this pull request doing?
buildConfigExtensionIdentifiersBreakdown(a plain local-vs-remote field diff using the order-insensitive array comparison from Add order-insensitive deep object comparison to cli-kit #8044) andconfigExtensionsIdentifiersReleaseBreakdown.releaseto them: the config breakdown now compares the version being released against the app's active version instead of re-fetching remote configuration.Only affects the
releasecommand; the shared helper is reused by #8055.releaseconfig diff is computed/displayed — consider apatchchangeset.How to test your changes?
pnpm --filter @shopify/app exec vitest run src/cli/services/release.test.ts src/cli/services/context/breakdown-extensions.test.ts