Repository navigation
Integrate SQL bus, independent requests and installer runtime ownership - #2620
Merged
Merged
Conversation
…refactor/p426-wake-delivery-seq # Conflicts: # src/agent_comms/registration.py
…nto refactor/p424-bus-history-seq
…/p424-bus-history-seq
…-file-bus-filebus
…nto refactor/p426-wake-delivery-seq # Conflicts: # tests/test_bus_files.py # tests/test_install.py
…refactor/p426-wake-delivery-seq # Conflicts: # tests/test_bus_page_index.py # tests/test_private_bus_checkpoint.py
…nto refactor/p426-wake-delivery-seq
…refactor/p426-wake-delivery-seq
…nto feat/p415-watched-bus
|
debt-tools at de859dc, every finding: |
# Conflicts: # src/agent_comms/todos.py
|
debt-src at de859dc, every finding: |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old bus kept records, message identities and request state in competing paths. Retained DMs could follow a reused name, orders competed for the commander's single goal, and the installer could report success before its cleanup failed. This batch moves history into SQLite, gives independent requests to OwnerRequest/TodoStore, preserves destination identity, and keeps install reporting alive through source retirement.
This integrates #2616, #2619, #2621, #2625 and #2628 with their merge ancestry. It includes the separable native watcher and nested-value codec repairs from #2622. The later bus-lock, CLI registry, heartbeat and reply-policy lanes remain separate; the rejected schema-skip prototype is excluded.
Ownership changes:
Paired Toad #1138 is merged as dab0047a426e4ac3b8bcd796c79d06edfc014ff9. Its replacement source, pages and observation become current together; canceled preparation leaves the old view usable. Filter/style/stale-read paths use that same owner. Core's ConversationObservation.matches_stores supplies the actual unobserved/captured contract.
Validation on the recorded checkpoints:
NRA's complete integration inventory covers 1,242 Core/tools/tests/Toad modules, 6,896 original and 6,697 projected classes, zero parse omissions. All 27 lexical ordinary-publication calls supply a destination. Supplemental installer and observation inventories retain before/after owner/consumer sites. Dynamic rebinding remains outside this syntax evidence. Detailed source maps, exact commands and failed/superseded runs remain in the existing evidence and root handoff.
The source batch and actual installer checks are ready. Paired machine installation and installed native fork/immediate-open/first-reply, fresh DM/reply/tab-return, and filtered replacement/style/older-read qualification remain open with the existing integration and Toad owners. The live pair remains unchanged until that installation.
CI is deferred under the standing owner decision. PR #2631 records the 98 historical hosted finding dispositions and their limits, including remaining class-object/cache and forwarded-key checker diagnostics, wider request/delivery typing owners and an unnamed UncarriedRecordFormat screening warning. This batch does not claim the wider plans or every screening lead are complete. Source review and actual application evidence remain distinct from those counts.