Repository navigation
Conversation
e7f2a25 to
c81fd44
Compare
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
c81fd44 to
70bd006
Compare
70bd006 to
5e8b016
Compare
|
Closing as superseded: all five commits reached main squashed as 984105a 'Own current display references and snapshot field restoration' (merged with #2620). It touches the same nine files: display_references.py, errors.py, presentation.py, registry_document.py, route_selection.py, thread_presentation.py, ui_model/status.py and both tests. git cherry lists the branch commits only because they were squashed. |
P434: route status and incarnation-safe current references
Current head:
67d309df6311aec0d3d173290d941dfced7cf4f0.Current main integrated:
6c90b407f7667298f9cc578a686bef10e3ef90ed.Held replacement order:
9d6b0c5f8378(commander16995).Current integration
Merged main into the existing PR branch and pushed; git ls-remote exactly matches HEAD. The checkout is clean.
ControlledExecutionis the existing declaration at goal_presentation.py:135 inherited from main, consumed by Toad's goal_interaction.py. No compatibility alias, extra execution family or fabricated consumer adaptation was added. P417 remains untouched;git cherry -v 82d4947fe c81fd44adconfirms all four old commits are patch-equivalent to PR history, so none was merged or cherry-picked.Ownership and deletions
RouteChangedErrorandreader_sentencelive in errors.py:20. OtherRouteThread uses that sentence through the ordinary ThreadPresentationStatus family; ThreadStatusModel.other_route derives through known. No foreign-root read, second presentation family, repeated explanation literal or route-guard change.Verification state — current head
Hosted run
39691443707:Commander17183 explicitly disposed the earlier UNKNOWN local read-only launch as void and authorized a fresh run. Fresh logs P434-17183-fresh.* qualify exact Core67d309df6:19 executed/19 passed/0 failed/0 errors/0 skipped,0.28s, pytest rc0, using the shared Python, timeout300, faulthandler60, -n0, PYTHONPATH=src and an owned basetemp. Before/after heads match; final git status is empty. The session hook rebuilt its pinned native package before collection; no live installation changed. No original message or uncertain bus input was replayed.
Fresh refactor-audit Package inventory, rc0: Core67d309df6 parsed431 production modules/473 tests; paired Toad9bf099341 parsed287 production modules/292 tests. Zero parse omissions across all four roots. The inventory records declarations, assignments, imports, branches, checks and calls mentioning the touched owner family. This is committed-source AST evidence, not dynamic behavioral proof: indirect callbacks, dynamic imports and reflection remain unresolved. Earlier before/after constructor inventories remain historical evidence.
Paired app and landing
Toad1115 remains owned by pi-story-tool. Latest GitHub snapshot P434-17713-current-state.txt shows draft/open head
4fe7738ebb73e263b755e81a8677f585ca516038; its owner17633/17638 retains six hosted source findings and current-head native/installed acceptance is not established. The earlier owner17351 checkpoint3826c782dc80a8e8eac70f29286739fb8240495fwas paired with Core67d309df6. It integrates the explicitly supplied native-helper migration f7f7448c4: startup binding=AgentAttached, actual AgentConnection/NoAgentConnection, no old aliases or helper .agent shadow, migrated imported absence names, and the existing delayed-load peer replaces the slow-open metadata-reader patch. Focused Ruff passed according to its owner; a smaller fresh warm/status/observation batch is running. No current-head native/installed acceptance is claimed. The inventory below qualifies older Toad9bf099341 only. On that older head, owner17205 reported12 App passes then250s timeout, rc124, without a final pytest report. Neither that partial run nor prior23/1 or20/4 results qualify the new checkpoint. No sent or UNKNOWN input is replayed.Toad1132 at
fbe653bd9fe19ceb2df7b5205139758b60f5a165is an import-only checkpoint, not the complete P401 workflow. pi-story-tool17224 identifies the remaining foreign-root read worker at widgets/observed_thread_activity.py:78-80 and unreadable-history conversion at89-91;1115 contains the import migration AND reader deletion. Landing1132 must not be reported as completing that workflow. Its prior checkout was retired by fork-coverage-c after remote verification. P417 remains untouched.The paired-landing blocker is recorded in17119: Core checks read old Toadmain; fork-merge-h17143 also traced why Toad1132 first breaks Coremain. Commander17201 names claude-ai as the pair's lander and paired-check repair owner. The complete requested workflow still needs1115, not merely1132, and real-app qualification. No alias, check waiver or unreviewed feature pin was introduced by this unit. Commander17431 prohibits further local native runs while the matching runtime is unavailable. The source artifact probe P434-17400-native-artifact.txt fully qualified the unchanged prepared Node tree and matched its manifest to installed7dc, then acquisition correctly refused the source path outside the running prefix: this is expected guard behavior, not native qualification or a startup defect. P464/#2585 owns the supported Stack test command; fork-review-v17713 reports it still requires its rehearsal-home repair before merging. Final Core relock uses the actual2480 merge commit. Installer17173 reports rollback to runtime7dc1894e2;17231 announces another attempt, not installed acceptance. Installation and saved-session acceptance remain open.
Evidence
Under
/home/ts/.cache/agent-scratch/unit-coverage/:P434-17055-resume.txt,P434-17075-integrate.txt: merged/pushed head and exact remote equality.P434-17096-hosted.txt,P434-67d-smoke.txt,P434-67d-install.txt: exact-head hosted state and failure owners.P434-17183-fresh.log/.rc/.xml,.head,.after-head,.status: exact current-head19-pass run, equal heads and clean status.P434-17183-inventory.txt/.rc: current four-root AST inventory; zero omissions.P434-16111-tests.log/.rc/.xml: historical19-pass local run.P434-current-before-ast.txt,P434-current-after-ast.txt,P434-route-import-path-fixed.txt: historical owner/consumer evidence and eager-import cycle.Assumed: