Repository navigation
Read a fresh bus as empty, type every git failure, keep test git off the caller's repo - #2784
Merged
Merged
Conversation
…off the caller's repo test_storage_violations x5 was red on main with SQLITE_CANTOPEN on wire/bus.sqlite3. - Breaking commit 1673313 (SQLite bus integration, via #2620): Bus.observing opened bus.sqlite3 mode=ro, so a root before its first bus write raised CANTOPEN. TypedStore.snapshot already owned "a store before its first write reads as its declared empty schema"; Bus never inherited it. The absent branch moves onto WalStore.committed_or_empty and both inherit it. - Repo.git raised CalledProcessError while goals.CheckedCommit.git raised GitCommandFailed: one git runner copied with drift (IMPL-12). UnitState.read only turns GitCommandFailed into an Unreadable card, so a unit whose worktree vanished crashed the heartbeat. One runner on Repo now (C locale, 60 s, GitCommandFailed, which moves to repo.py); CheckedCommit.git deleted. - StorageViolation.scan_observed skipped Unreadable units, so a gone declared home (the exact case StorageHomeMissing names) never reported once 7dc76e0 made the branch read part of require_read. Storage reads the filesystem, so it scans every held observed unit. - tests/conftest.py strips every GIT_* variable at import. git bisect run from a linked worktree exports GIT_DIR; a fixture's plain `git -C tmp init` then re-initialised the caller's checkout with core.bare=true (the flip seen 3x on 10-23) and registered fixture worktrees on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
debt-src at b7a27cf, every finding: |
…phaned debt-src grew LintFindings by one in change_report.py, repo.py and unit_state.py. The exception moved into repo.py kept a name without the Error suffix (N818), change_report.py still imported CheckedCommit it no longer used, and unit_state.py's import block was unsorted. goals.py's os import lost its last user with CheckedCommit.git. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_storage_violations x5 was red on main with SQLITE_CANTOPEN on wire/bus.sqlite3.
opened bus.sqlite3 mode=ro, so a root before its first bus write raised
CANTOPEN. TypedStore.snapshot already owned "a store before its first write
reads as its declared empty schema"; Bus never inherited it. The absent
branch moves onto WalStore.committed_or_empty and both inherit it.
GitCommandFailed: one git runner copied with drift (IMPL-12). UnitState.read
only turns GitCommandFailed into an Unreadable card, so a unit whose
worktree vanished crashed the heartbeat. One runner on Repo now (C locale,
60 s, GitCommandFailed, which moves to repo.py); CheckedCommit.git deleted.
home (the exact case StorageHomeMissing names) never reported once
7dc76e0 made the branch read part of require_read. Storage reads the
filesystem, so it scans every held observed unit.
a linked worktree exports GIT_DIR; a fixture's plain
git -C tmp initthenre-initialised the caller's checkout with core.bare=true (the flip seen 3x
on 10-23) and registered fixture worktrees on it.
Proof (local, -p no:xdist):
too (MalformedRecord: Expected float, received RecordedCreationTime): not this change, no owner.
git initflipsthe scratch repo to core.bare=true; with this conftest, test_storage_violations under the
same GIT_DIR leaves it false with its worktree list unchanged.
Not folded here (named for an owner):
merge-base --is-ancestoris still answered by fourrunners (repo.py Repo.contains, build_identity.py:131, todos.py:388, installer/upgrade.py:777), IMPL-13.
🤖 Generated with Claude Code