Repository navigation
Conversation
agent-comms PR 2480 (P434) moves the route-change error from route_selection.RouteChanged to errors.RouteChangedError, because putting it back in route_selection recreates the import cycle presentation -> route_selection -> active_route -> private_nk_entrypoint -> coordination_database. Every Toad importer now takes it from agent_comms.errors; no alias, no re-export. Lands paired with 2480. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
left a comment
trissim
left a comment
There was a problem hiding this comment.
head-review: sent back at 54f185a. The change itself is right: all six importers catch and raise RouteChangedError from its leaf owner agent_comms.errors (class at errors.py:20 on #2480's head), and no route_selection.RouteChanged reference is left in this diff. Two things keep it from landing as the pair:
- The lock still pins a Core without the name, at uv.lock (agent-comms
source = ...#2e51f3b67, set by #1129). The ratchet reads Core frompyproject.toml's branch (main, ci.yml:37-52), so its sixTypeErrors +1(agent_session.py, comms_updates.py, comms_root.py, session_navigation.py, target_commands.py, thread_actions.py) only mean that main doesn't have #2480 yet, and they clear once it merges. But anything installed from the lock gets 2e51f3b67, whereagent_comms.errors.RouteChangedErrordoesn't exist. Every one of these modules would then fail at import. Fix: after #2480 merges, relock Core to that merge commit (uv lock --upgrade-package agent-comms) in this PR and push, so Toad and its lock land together. - Its pair isn't green: agent-comms #2480 (5e8b01627) currently fails debt-src, smoke and install-rehearsal. Per the pairing, this waits for #2480 green, then the relock, then a re-review on the new head.
|
Superseded: origin/main already carries these renames (no drain_candidate_catchup or RouteChanged left in src or tests). |
P434: consume the route error from Core's leaf error owner
Paired with OpenHCSDev/agent-comms#2480. The six Toad consumers import
RouteChangedErrorfromagent_comms.errors: agent_session.py, comms_updates.py, comms_root.py, session_navigation.py, target_commands.py and thread_actions.py. No alias, re-export or restored Core error declaration. Importing the exception back from route_selection recreates the eager coordination-database startup cycle.Current checkpoint
Per commander instruction15803, merged current Toad main
242e173ff5509818dbde0d97d3eb4d490227418finto the existing PR branch. Published mergefbe653bd9fe19ceb2df7b5205139758b60f5a165; git ls-remote exactly matched HEAD. Separate checkout/home/ts/wt/unit-coverage--P434--toad; original commander checkout and protected Core P417 unchanged.Main's lockfile now resolves Core to
2e51f3b67fc7ee4acf2c8ee6e34f42d6528d3a70, replacing the obsolete pre-merge lock. This is NOT the final pairing: Core#2480 is still OPEN at5e8b01627925a75c6c18899a2783ea38b21fb70e, with no merge commit. Relock Core through uv to that PR's actual merge commit after it lands. No hand-edited lock, environment installation, auto-merge or installed-success claim.Verification
git diff --check: passed; checkout clean after publication.ui_theme; corrected the interpreter to the existing installed runtime, without installing packages.Receipts under
/home/ts/.cache/agent-scratch/unit-coverage/:P434-toad-main-merge.txt,P434-toad-main-publish.txt,P434-toad-paired-imports.txt,P434-toad-paired-imports-installed-deps.txt.Assumed: