Repository navigation
P401: discover session owners through a screen-free scope - #1115
Merged
Merged
Conversation
# Conflicts: # src/toad/wire_history.py # tests/textual/test_conversation_value.py
trissim
marked this pull request as ready for review
October 21, 2026 12:30
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
trissim
marked this pull request as draft
October 21, 2026 13:27
Keep main's retained transcript renderer, source replacement, stable thread targets and committed-send owners. Apply P401's launch binding and screen-independent SessionScope to their consumers. Restore Core's main dependency and matching lock; remove the retired qualification workflow changes and tests that intercept project methods.
trissim
marked this pull request as ready for review
October 23, 2026 10:37
# Conflicts: # src/toad/acp/comms_updates.py # src/toad/widgets/conversation.py
…rors Every parameter the PR added in src/toad now carries the type its callers pass: SessionScope's abstract methods and both overrides (CoordinationAccess, Conversation, TranscriptCursor | None, TranscriptPublicationState, UserInputSubmitted, type[DmConversation], the presented callback), with **bounds spelled out as the four keywords acp/transcript_reader.py passes. rows_in takes SidebarGroup[CommsRow]; workspace visible_target/target_for_mode take root: Path | None and identity: str. NoTarget's menu_context/show_menu overrides are deleted: NoTarget.rows_in returns (), so no row ever carries it, and both are reached only through a row's target. cli.get_agent_binding no longer turns AgentReadError into NoAgent(). Its only caller is `toad run -a NAME`; a user who asked for an agent whose definitions cannot be read now sees the read error instead of a session silently launched without the agent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session navigation, transcript reads and launch state currently depend on concrete screens and optional agent data. P401 puts those responsibilities on
SessionScope, typed launch bindings and transcript scopes; mounted views implement the capabilities, and consumers use them directly. Authored versus thread-following titles are distinctSessionNamemembers, andFlashowns feedback without a forwarding method.Merged Toad main
b971751330into the branch. Core now usesbranch = "main";pyproject.tomlanduv.lockexactly match main. Removed the old Core-head pin, obsolete workflow/documentation changes, and the old qualification narrative.Conflict resolutions (all 53 files):
pyproject.toml,uv.locksrc/toad/acp/{agent_session,comms_updates,transcript_reader}.pysrc/toad/{comms_root,conversation_kind,transcript_preparation,transcript_state}.py,src/toad/widgets/{session_details,session_tabs}.pysrc/toad/{conversation_comms_handlers,conversation_submission,delivery_failure_view}.py,src/toad/widgets/prompt.pysrc/toad/{navigation_target,target_commands,session_entry,session_navigation,session_observation,session_presentation,session_tracker}.py,src/toad/screens/comms.py,src/toad/widgets/{channel_activity,conversation}.pysrc/toad/transcript_publication.py,src/toad/widgets/{comms_chat,transcript_history,wire_history}.py,src/toad/wire_history.pytests/native/{test_native_client_requests,test_native_goal_bar}.py,tests/support/{native,native_steps,routes}.py,tests/textual/{test_conversation_kind,test_conversation_value,test_hidden_session_retirement,test_historical_notification_source,test_key_bursts_move_focus_to_the_editor,test_plan_display,test_prompt_completion}.pytests/native/test_thread_open_during_slow_load.py,tests/support/{agents,observed_app,workspace}.py,tests/textual/{test_channel_updates_and_returns,test_initial_prompt_handoff}.pytests/support/failed_close_app.py,tests/textual/{test_close_tab,test_default_route_flip,test_interrupted_send,test_stale_route_writes}.pyDeleted 17 tests that patched or intercepted project behavior, including the conflict-side cases above and the affected binding-change, queued-send, navigation-read, shutdown and transcript-fencing cases. Removed dead helpers/imports; provider protocol substitutes and unrelated main database tests remain.
Source relationships were checked with AST inventories and semantic reads of the shared owners and consumers. Interpreter-imported all 50 changed production modules and 52 surviving changed test/support modules against Core main
051fe6b617; all imported. The concrete screens and conversation classes remain concrete. No pytest run.Assumed:
Review correction: SessionScope now answers matches_launch directly (false by default, native binding override). Deleted WorkspaceSessions.native_origins and its own-class isinstance filter; launch lookup uses the existing views. Migrated the three test assertions that referred to the deleted property. All three changed production modules import with Core main and the requested db2a3b39e runtime. One isinstance call deleted, none added; raw AST total is 109, equal to main (110 at the reviewed head).