Send more metadata with a run (release-2.18.0) - #5064
Merged
Conversation
The entry described the wire format; what a user needs to know is the names they can read in job code, and that it needs a newer worker.
|
The PR adds a Security Review ✅
|
3 tasks
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-2.18.0 #5064 +/- ##
================================================
Coverage ? 90.6%
================================================
Files ? 422
Lines ? 20036
Branches ? 0
================================================
Hits ? 18161
Misses ? 1875
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same change as #5062, targeted at
release-2.18.0instead ofmain, so it can go into 2.18.0-pre2 for QA.Joe's two commits cherry-picked onto the release branch, plus a changelog reword. Supersedes #5062, which should be closed.
Gives job code the work order, workflow and project ids on the
metaglobal. Needs the worker on 1.29.1, which is a separate bump on this branch (this branch is still pinned to ^1.27.4).Validation steps
log(meta)using common.workOrderId,workflowIdandprojectId.Additional notes for the reviewer
Already reviewed on #5062 - the diff here is identical apart from the changelog, where this branch's Added section didn't have the #4984 entry to sit alongside.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy