Skip to content

Send more metadata with a run (release-2.18.0) - #5064

Merged
elias-ba merged 5 commits into
release-2.18.0from
release-2.18.0-run-metadata
Aug 14, 2026
Merged

Send more metadata with a run (release-2.18.0)#5064
elias-ba merged 5 commits into
release-2.18.0from
release-2.18.0-run-metadata

Conversation

@elias-ba

@elias-ba elias-ba commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Description

Same change as #5062, targeted at release-2.18.0 instead of main, so it can go into 2.18.0-pre2 for QA.

Joe's two commits cherry-picked onto the release branch, plus a changelog reword. Supersedes #5062, which should be closed.

Gives job code the work order, workflow and project ids on the meta global. Needs the worker on 1.29.1, which is a separate bump on this branch (this branch is still pinned to ^1.27.4).

Validation steps

  1. Run a workflow from the bundled worker with log(meta) using common.
  2. Against worker 1.29.1 the meta object should include workOrderId, workflowId and projectId.
  3. Against an older worker it should still run, just without those keys.

Additional notes for the reviewer

Already reviewed on #5062 - the diff here is identical apart from the changelog, where this branch's Added section didn't have the #4984 entry to sit alongside.

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our Responsible AI Policy

josephjclark and others added 3 commits August 14, 2026 16:57
The entry described the wire format; what a user needs to know is the
names they can read in job code, and that it needs a newer worker.
@github-project-automation github-project-automation Bot moved this to New Issues in Core Aug 14, 2026
@github-actions

Copy link
Copy Markdown

The PR adds a meta field to the payload sent to workers over the RunChannel, exposing work_order_id, workflow_id, and project_id (all derived from the already-loaded run). This is server-to-worker communication, and the worker is JWT-authenticated to the specific run before this render runs (run_channel.ex:33). No new query, endpoint, or persistence is introduced.

Security Review ✅

  • S0 (project scoping): New meta field is server-to-worker payload derived from a run the worker was already token-authorized to fetch (run_channel.ex:33); no new query or user-facing entrypoint, and project_id was already in the same plan (run_with_options.ex:24).
  • S1 (authorization): N/A, no new web-layer actions or policy-gated operations added.
  • S2 (audit trail): N/A, render_meta/1 is a read-only render function with no config writes.

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-2.18.0@9b7934f). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-2.18.0   #5064   +/-   ##
================================================
  Coverage                  ?   90.6%           
================================================
  Files                     ?     422           
  Lines                     ?   20036           
  Branches                  ?       0           
================================================
  Hits                      ?   18161           
  Misses                    ?    1875           
  Partials                  ?       0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elias-ba
elias-ba merged commit 7850133 into release-2.18.0 Aug 14, 2026
7 checks passed
@elias-ba
elias-ba deleted the release-2.18.0-run-metadata branch August 14, 2026 18:49
@github-project-automation github-project-automation Bot moved this from New Issues to Done in Core Aug 14, 2026
@elias-ba elias-ba mentioned this pull request Aug 15, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants