Clear the advisories flagged on release-2.18.0 - #5066
Merged
Conversation
Cherry-picks the postgrex 0.22.4 and phoenix_live_view 1.0.19 lock bumps from main (#5056, #5063) so 2.18.0 doesn't ship with advisories its own dependency audit raises, and so the lint job on this branch can pass. Lock file only - both sit inside the requirements already in mix.exs. The changelog notes go under Unreleased rather than 2.18.0-pre1, which shipped without them.
|
This PR is a Security Review ✅
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-2.18.0 #5066 +/- ##
================================================
Coverage ? 90.6%
================================================
Files ? 422
Lines ? 20032
Branches ? 0
================================================
Hits ? 18159
Misses ? 1873
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picks the two lock-file bumps from
main(#5056 and #5063) ontorelease-2.18.0, so 2.18.0 doesn't ship with advisories its own dependency audit raises:This branch is currently on the older version of both, so
mix deps.auditfails and every PR opened againstrelease-2.18.0shows a red lint job - #5064 and #5065 both do. This clears that as well.Lock file only: both new versions sit inside the requirements already in
mix.exs, so nothing else moved. The changelog notes go under Unreleased rather than 2.18.0-pre1, which shipped without them.Collapsed into one commit because the two are the same change with one purpose; the original commits are on main if the history is wanted.
Validation steps
mix deps.getmix deps.audit --ignore-file .mix_audit.ignore- should reportNo vulnerabilities found.lintjob should pass, here and on the other release PRs once they pick this up.Additional notes for the reviewer
No application code changes, so the risk is a patch regression in either dependency rather than anything in this diff.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy