Bump bundled worker to 1.29.1 (release-2.18.0) - #5067
Merged
Conversation
Brings in the worker side of the run metadata change, so a job can read work order, workflow and project ids from the meta global. Without this the release would bundle 1.27.4 and those keys simply wouldn't appear. Mirrors the last worker bump: the pin, the regenerated lock file, and the version the integration test asserts on.
Security Review ✅
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-2.18.0 #5067 +/- ##
================================================
Coverage ? 90.6%
================================================
Files ? 422
Lines ? 20032
Branches ? 0
================================================
Hits ? 18152
Misses ? 1880
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps the bundled worker from 1.27.4 to 1.29.1 on
release-2.18.0.This is the other half of #5064. Lightning sends the new
metaobject, but only worker 1.29.1 maps it onto themetaglobal a job can read. Without this bump the release would bundle 1.27.4 andmeta.workOrderIdsimply wouldn't appear, with nothing failing loudly - there's no version negotiation between Lightning and the worker.Note this branch was on 1.27.4, not 1.29.0: the earlier bump (#5050) went to
mainand was never cherry-picked here.Mirrors #5050 - the pin, the regenerated lock file, and the version the integration test asserts on. The lock file also moves engine-multi to 1.13.0 and lexicon, as transitive deps of the worker.
Validation steps
log(meta)using common.metashould includeworkOrderId,workflowIdandprojectIdonce Send more metadata with a run (release-2.18.0) #5064 is in.test/integration/web_and_worker_test.exsasserts the worker version it sees, now 1.29.Additional notes for the reviewer
Worth merging after #5064 so the feature and the worker that supports it land together.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy