merge queue: checking #12770 on main (c20b99c), stacked on #12769 and #12764 - #12787
Closed
mergify[bot] wants to merge 6 commits into
Closed
merge queue: checking #12770 on main (c20b99c), stacked on #12769 and #12764#12787mergify[bot] wants to merge 6 commits into
mergify[bot] wants to merge 6 commits into
Conversation
Review Requirements' DefaultReviewCond anchor required #approved-reviews-by >= 2; drop it to 1 so a single approval is enough to merge on Mergifyio/docs, for everyone, not another carve-out. DefaultReviewCond is shared by the Hotfix Review Requirements protection (`or: *DefaultReviewCond`) and by the request-review pull request rule, so both move with it. That also makes the hotfix-specific hotfix Review Requirements' escapes dead: its eng-mgr-with-one-approval and devs-with-eng-mgr-or-fix/revert-title branches only ever granted "one approval clears review", which the new default already grants to any author. Removed them along with the now-redundant `label != hotfix` guard in the request-review rule's condition, which existed only to avoid double-counting that escape. Checked the repo's GitHub side: of its 9 rulesets, only "Require pull request for default branch" carries a pull_request rule, and its required_approving_review_count is 0 — no ruleset conflicts with the new threshold. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Change-Id: I9983de27602a153f5510b61cc8bb5c91a86e7705
docs#12728 dropped the real-invoice billing example from billing.mdx —
both <Image> uses and both import lines — and left
invoice-previous-period.png and invoice-next-period.png behind with
nothing pointing at them.
A repo-wide sweep for the same pattern (path-relative-to-images/, not
basename — see the next commit) turned up five more:
merge-protections/freeze-main.png and stacked-gh-pr.png /
stacked-mergify-pr.png were never wired into the pages they were added
for, and workflow/writing-your-first-rule/{summary,config-editor}.png
belonged to a page removed wholesale in 068ac36.
Deleting first, before the check that follows, so that check is never
red on main.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Change-Id: I770291bedc49acb609264a58b7032c9fad738c58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
#12770 is queued for merge on branch main (c20b99c).
Stacked behind 2 pull requests queued ahead of this batch, not part of it. These checks run on a tip that also carries their commits, so a failure here can come from them as much as from #12770.
Queued ahead of this batch:
This pull request has been created by Mergify to speculatively check the mergeability of #12770.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]schedule=Mon-Fri 09:00-17:30[Europe/Paris]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = renovate[bot]author = mergify-ci-bot-head ~= ^docs-agent/📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = diagram-tokenscheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/Required conditions to stay in the queue:
github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = renovate[bot]author = mergify-ci-bot-head ~= ^docs-agent/📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = diagram-tokenscheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/author != dependabot[bot]author != mergify-ci-botauthor != renovate[bot]head ~= ^docs-agent/