fix(mergify): drop docs default review requirement to one approval - #12769
Open
jd wants to merge 1 commit into
Open
Conversation
Review Requirements' DefaultReviewCond anchor required #approved-reviews-by >= 2; drop it to 1 so a single approval is enough to merge on Mergifyio/docs, for everyone, not another carve-out. DefaultReviewCond is shared by the Hotfix Review Requirements protection (`or: *DefaultReviewCond`) and by the request-review pull request rule, so both move with it. That also makes the hotfix-specific hotfix Review Requirements' escapes dead: its eng-mgr-with-one-approval and devs-with-eng-mgr-or-fix/revert-title branches only ever granted "one approval clears review", which the new default already grants to any author. Removed them along with the now-redundant `label != hotfix` guard in the request-review rule's condition, which existed only to avoid double-counting that escape. Checked the repo's GitHub side: of its 9 rulesets, only "Require pull request for default branch" carries a pull_request rule, and its required_approving_review_count is 0 — no ruleset conflicts with the new threshold. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Change-Id: I9983de27602a153f5510b61cc8bb5c91a86e7705
Contributor
Merge Protections🔴 2 of 7 protections blocking · waiting on 👀 reviews
🔴 👀 Review RequirementsWaiting for
This rule is failing.
🔴 🔎 ReviewsWaiting for
This rule is failing.
Show 5 satisfied protections🟢 📃 Configuration Change RequirementsMergify configuration change
🟢 🤖 Continuous Integration
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
There was a problem hiding this comment.
🔵 Needs a closer look
It changes merge governance (required approvals) and should be explicitly confirmed by a human reviewer for policy/impact alignment.
Pull request overview
This PR updates the repository’s Mergify configuration to reduce the default approval threshold from two approvals to one, and removes now-redundant hotfix-specific review “escape” logic that previously existed to allow one-approval merges in limited cases.
Changes:
- Lower
DefaultReviewCondfrom#approved-reviews-by >= 2to>= 1. - Remove the dedicated hotfix review-escape conditions (
&HotfixReviewCond) and simplify hotfix protections to reuse*DefaultReviewCond. - Simplify the “request review” pull request rule by removing the hotfix-specific guard and relying solely on
not: or: *DefaultReviewCond.
File summaries
| File | Description |
|---|---|
.mergify.yml |
Adjusts default review success conditions and simplifies hotfix and review-request logic accordingly. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jd
marked this pull request as ready for review
September 11, 2026 07:00
kozlek
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Requirements' DefaultReviewCond anchor required
#approved-reviews-by >= 2; drop it to 1 so a single approval is
enough to merge on Mergifyio/docs, for everyone, not another
carve-out.
DefaultReviewCond is shared by the Hotfix Review Requirements
protection (
or: *DefaultReviewCond) and by the request-reviewpull request rule, so both move with it. That also makes the
hotfix-specific hotfix Review Requirements' escapes dead: its
eng-mgr-with-one-approval and devs-with-eng-mgr-or-fix/revert-title
branches only ever granted "one approval clears review", which the
new default already grants to any author. Removed them along with
the now-redundant
label != hotfixguard in the request-reviewrule's condition, which existed only to avoid double-counting that
escape.
Checked the repo's GitHub side: of its 9 rulesets, only "Require
pull request for default branch" carries a pull_request rule, and
its required_approving_review_count is 0 — no ruleset conflicts
with the new threshold.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com