docs(agent): fork pull requests are now refused when update_bot_account rebases them - #12764
Conversation
Merge Protections🟢 All 6 merge protections satisfied — ready to merge. Show 6 satisfied protections🟢 🤖 Continuous Integration
🟢 👀 Review Requirements
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 Reviews
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
Both splits are done: the billing Plan page and the quarantine page have each I took a third one out on the same grounds rather than leave the complaint What is left here is exactly what the title names: the fork and |
Merge Queue Status
This pull request spent 3 minutes 46 seconds in the queue, including 2 minutes 29 seconds running CI. Required conditions to merge
|
4 participants
The Merge Strategies page carried two notices calling fork pull requests with
update_method: rebaseand anupdate_bot_accounta deprecation. It is arefusal now: a pull request in that shape is turned away when it is queued, on a
queue that runs its checks in place. Both notices also sent readers to
update_method: merge, which afast-forwardin-place queue rejects outright,so part of the audience was being migrated onto a configuration that does not
validate. The callouts now state the refusal, the remedy that works everywhere
(unset the account and let the rebase go through GitHub's API as Mergify), and
the one fork pull request that needs the account instead. The in-place section
of the Batches page, which recommends setting
update_bot_accountwithoutmentioning that cost, links to them.
Separately,
autosquashwas removed from the engine and two pages stilldescribed it as a working option: the
rebaseaction page offered it as a thirdway to satisfy the action's requirement, which no longer exists, and the Direct
Merge page listed it among the conditions to check. Both are deletions. The
Quarantine page credited its data to CI Insights twice, on a Test Insights page.
And the billing page's Plan screenshot is replaced by the table it was a picture
of, which also picks up the columns the old prose left out.
Evidence: the
autosquashandupdate_bot_accountdescriptions in theconfiguration schema, the engine's rebase-requirements builder, and the
fork-rebase refusal it assembles for the check run.