Repository navigation
refactor: collapse leftover trial, timezone, and booking helpers - #4795
Merged
Merged
Conversation
Share destination conference resolution, celebration keys, and awaiting-checkout trial copy. Drop dead checkout holdSource and the timezone banner alias. Co-authored-by: tyler <tyler@switchback.tech>
tyler-dane
marked this pull request as ready for review
October 24, 2026 01:22
tyler-dane
added
the
agent-automerge
tyler-dane
enabled auto-merge
October 24, 2026 01:22
Contributor
|
Boot bundle: 527.5 KB gzip (+0.0 KB vs main) |
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
What and why
Nightly simplification of merges after #4762. Booking public pages and host-alert emails share one destination-conference helper, hint celebration keys have one builder,
awaiting_checkoutbanner copy uses the shared trial label and length, recoverable booking ops alias the in-flight status set, and the connection report reuses the sync stale window. DeadholdSource, the unused signup-trial terms helper, the timezone-banner alias, and unused celebration-storage exports are gone. Hide-tips acceptance docs now match palette mute. No product behavior change.Verify
Selected local checks passed:
test:core,test:web,test:backend:fast,test:scripts:fast,type-check,lint,knip,test:a11y.test:e2eran 295 passed, 2 failed under parallel load in untouched specs, then both passed on isolated retry:e2e/calendars/calendar-experience.spec.ts(a read-only event can be hidden...) 3.4se2e/navigation/week-grid-event-alignment.spec.ts(stays aligned after life view then week with blog utm params) 18.4sThe diff does not touch hide-event or week-grid alignment. Sandbox Playwright flake, not a local blocker; CI decides.
Note
Low Risk
Mostly deduplication and export cleanup; booking conference resolution is centralized but unchanged in logic, with tests noted in the PR description.
Overview
Consolidates duplicated helpers after recent merges: booking public pages and host-alert emails now share
resolveBookingDestinationConference; recoverable operation statuses alias the in-flight set; host-email enqueue usesisBookingHostEmailKind.Calendar-web trial/checkout copy pulls from shared constants (
TRIAL_START_PRIMARY_LABEL,BILLING_PLAN.TRIAL_LENGTH_DAYS); dead code is removed (checkoutPanelActions.holdSource,signupTrialStepTermsLine, timezone-banner alias, unused celebration-storage exports). Timezone mismatch checks callshouldShowTimezoneMismatchdirectly; hint celebration keys build throughhintShortcutCelebrationKeyForPart.Ops/docs: the connection report’s stale-importing window matches sync’s
CONNECTION_STATE_REFRESH_STALE_AFTER_MS; onboarding docs describe muting tips via the command palette.Reviewed by Cursor Bugbot for commit 5fe5c4d. Bugbot is set up for automated code reviews on this repo. Configure here.