Repository navigation
refactor: collapse leftover graph timezone and series helpers - #4823
Closed
cursor[bot] wants to merge 1 commit into
Closed
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Share Graph IANA fallback and Prefer UTC headers, drop the duplicate exception recurrence branch, and reuse seriesIdOf plus stripRuleBounds. Co-authored-by: tyler <tyler@switchback.tech>
tyler-dane
marked this pull request as ready for review
October 25, 2026 01:19
tyler-dane
enabled auto-merge
October 25, 2026 01:19
Contributor
|
Boot bundle: 527.3 KB gzip (+0.0 KB vs main) |
tyler-dane
disabled auto-merge
October 25, 2026 05:02
Contributor
|
agent-loop: still conflicting after update-branch onto main. Closing so the issue can be relaunched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
What and why
Nightly simplification of merges after #4795. Graph IANA fallback and fractional-second stripping live in one helper; Prefer UTC headers share one constant with the normalizer timezone. The duplicate exception-recurrence branch is gone,
toRRuleinlines the one-line wrapper,seriesWriteKeyreusesseriesIdOf, and remainder-seriesstripRuleBoundssits next totruncateSeriesRulesBefore. No product behavior change.Verify
Selected local checks passed:
test:sync:fast,test:web,type-check,lint,knip,test:a11y.test:e2eran 294 passed, 3 failed under parallel load. Isolated retry:e2e/billing/signup-trial-step.spec.ts(awaiting checkout can explore...) passede2e/calendars/calendar-experience.spec.ts(holiday all-day dedupe) ande2e/calendars/cross-provider-duplicates.spec.tsstill fail because the fixtures stamp UTC today (2026-10-25) while the Denver week grid is still Sat 2026-10-24 (visible week Oct 18-24). The diff does not touch week windowing, holiday dedupe, or duplicate merge. Sandbox date-boundary flake; CI decides.VERDICT: FAIL
Failed: test:e2e
Note
Low Risk
Refactor and deduplication across Microsoft sync and optimistic recurrence helpers; intended no product behavior change, with narrow recurrence-mapping guard removal as the only subtle touchpoint.
Overview
Consolidates Microsoft Graph timezone and HTTP concerns:
graphTimeZoneToIanaandstripGraphDateTimeFractionmove intomicrosoft-graph-timezone, GraphPrefer: outlook.timezonestrings centralize inmicrosoft-http.constants, and readers/writers/normalizers/cancelled-occurrence mapping call those shared pieces instead of duplicating logic.On calendar-web,
seriesWriteKeyderives the master id viaseriesIdOf,stripRuleBoundslives besidetruncateSeriesRulesBefore(with a unit test), and several optimistic-mutation helpers are module-private only.mapRecurrencedrops the redundanttype === "exception"guard before theseriesMasterId/originalStartinstance path, andtoRRuleinlines a one-line pattern normalizer wrapper.Reviewed by Cursor Bugbot for commit f2391d5. Bugbot is set up for automated code reviews on this repo. Configure here.