Repository navigation
refactor: share hidden-draft strip, pointer gates, and outlook prefer headers - #4835
Merged
Merged
Conversation
… headers Week draft decks reuse createTimedEventLayout after stripping the active draft from the hidden set, the same helper Day already used. Empty-grid clicks share the mute/lock/pill gates. Graph Prefer UTC headers and seriesWriteKey stop duplicating nearby helpers. Co-authored-by: tyler <tyler@switchback.tech>
tyler-dane
added
the
agent-automerge
tyler-dane
marked this pull request as ready for review
October 26, 2026 01:18
tyler-dane
enabled auto-merge
October 26, 2026 01:18
Contributor
|
Boot bundle: 527.3 KB gzip (+0.0 KB vs main) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
What and why
Nightly simplification of merges after #4795 and #4827. Week draft decks reuse
createTimedEventLayoutafterwithoutHiddenEventIdstrips the active draft, matching Day. Empty-grid clicks share the mute, lock, and pill gates. Graph Prefer UTC headers live in one constant.seriesWriteKeyreusesseriesIdOf, remainder-seriesstripRuleBoundssits next totruncateSeriesRulesBefore, andtoRRuleinlines the one-line wrapper. No product behavior change.Verify
VERDICT: PASS
Selected local checks:
test:sync:fast,test:web,type-check,lint,knip,test:a11y,test:e2e.Note
Low Risk
Refactor-only consolidation with tests on new helpers; Microsoft constants preserve UTC Prefer behavior; touch areas (layout, sync) are broad but described as behavior-neutral.
Overview
Consolidates duplicated calendar-web and Microsoft sync logic after recent merges, with no intended behavior change.
Hidden drafts & grid layout: Adds
withoutHiddenEventIdso an active draft is removed from the hidden-id set while still laying out like a normal event. Day layers and WeekgetActiveTimedDraftDeckLayoutuse it; Week timed draft decks now callcreateTimedEventLayoutwith that set (aligned with Day) instead of hand-filtering hidden partners.Pointer hints: Extracts
arePointerHintEnvironmentGatesClosed(mute, dismiss, app lock, pill) forshouldTeachPointerHintand empty-grid slot/all-day intents, replacing a duplicate Week-only gate.Recurrence / optimistic edits: Moves
stripRuleBoundsnext totruncateSeriesRulesBeforewith tests;seriesWriteKeyusesseriesIdOf. Several optimistic mutation helpers are module-private; MicrosofttoRRuledrops a one-line wrapper.Microsoft Graph: Centralizes
outlook.timezoneand paged-eventPreferstrings inmicrosoft-http.constantsand wires reader, writer, normalizer, and master-categories throughMICROSOFT_GRAPH_OUTLOOK_TIMEZONE(still UTC).Reviewed by Cursor Bugbot for commit d7e6f92. Bugbot is set up for automated code reviews on this repo. Configure here.