Repository navigation
fix(parity): harden Desktop web parity title bar capture on macOS CI - #4668
Merged
Merged
Conversation
tyler-dane
added
agent-automerge
Cursor
tyler-dane
marked this pull request as ready for review
October 21, 2026 10:13
Fall back from CGWindow/screencapture to XCUITest window screenshots, write parity-window-top from the app when GPU capture works, and validate red/yellow traffic lights, nav title, and sidebar toggle without requiring green. Try multiple capture sources in CI instead of warn-only bypass. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
…capture" This reverts commit 9c81b97.
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/desktop-parity-screenshots-2ef3
branch
from
October 21, 2026 10:15
862eaae to
862b0f4
Compare
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4655
What and why
App-only follow-up to #4637 title-bar capture on
main: rasterize parity Phosphor icons, mirror the sidebar toggle, clamp the title bar to the main column during capture, and fall back towindow.screenshot()when CGWindow export times out. No changes torecord-macos-parity-captures.shorParityViewSnapshotExporter.swift(rebased ontomain, script/exporter match #4637/#4665 baseline).Verify
bun run verify --strict→ VERDICT: PASSDesktop web parity screenshots workflow on this branch (post-rebase).