Repository navigation
fix(macos): real window title bar capture (1280×120) with strict validation - #4655
Closed
tyler-dane wants to merge 9 commits into
Closed
tyler-dane wants to merge 9 commits into
tyler-dane wants to merge 9 commits into
Conversation
Drop content compositing; crop XCUITest window screenshots only. Validate traffic lights, June nav text band, and reject footer/grid crops. Group sidebar footer icons on the leading edge per web #4638. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
added
the
agent-automerge
tyler-dane
enabled auto-merge
October 21, 2026 00:50
Expand title-bar HStack to the window width so the trailing sidebar toggle matches web CalendarHeader layout. Harden mac-title-bar PNG validation with a top-right icon cluster check and XCUITest position assertions. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
disabled auto-merge
October 21, 2026 01:16
Contributor
Author
|
agent-loop: still conflicting after update-branch onto main. Closing so the issue can be relaunched. |
tyler-dane
removed
the
agent-automerge
Contributor
|
agent-loop: staging smoke passed on https://staging.compasscalendar.com after #4668. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes mac-title-bar.png parity: the sidebar toggle now lays out in the top-right of the unified title bar (full-width HStack, matching web
CalendarHeader).Changes
titleBarChromeHStack uses.frame(maxWidth: .infinity)and top-leading alignment so the phosphor sidebar toggle pins to the trailing edge beside traffic lights, nav, and month title.record-macos-parity-captures.shrequires a dark-pixel icon cluster in the right ~60px × top 52px band (replaces loose score that passed empty regions).minXis in the right ~28% of the window frame.Verification
Waiting on macos-capture after push. Prior run passed width/traffic lights but shipped a PNG without a visible toggle.
VERDICT: INCOMPLETEuntil macos-capture green with updated validation.