Repository navigation
fix(macos): title bar sidebar toggle visibility for parity capture - #4667
Closed
tyler-dane wants to merge 26 commits into
Closed
tyler-dane wants to merge 26 commits into
tyler-dane wants to merge 26 commits into
Conversation
Drop content compositing; crop XCUITest window screenshots only. Validate traffic lights, June nav text band, and reject footer/grid crops. Group sidebar footer icons on the leading edge per web #4638. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Expand title-bar HStack to the window width so the trailing sidebar toggle matches web CalendarHeader layout. Harden mac-title-bar PNG validation with a top-right icon cluster check and XCUITest position assertions. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Match web CalendarHeader: the toggle belongs on the main column's trailing edge, not over the open sidebar. Retarget parity PNG validation and XCUITest geometry to the content-track band. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Prefer screencapture -l for mac-title-bar PNG attachments, draw the title bar into a bitmap layer, and use primary text color on the sidebar toggle so CI pixel validation sees the phosphor icon beside the content track. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Split the trailing sidebar toggle into its own title-bar layer instead of flattening the full HStack with drawingGroup, which dropped the icon in real window captures while XCUITest still saw the button frame. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Place unified chrome in the content VStack so the AppKit week grid cannot composite over the sidebar toggle, mirror the phosphor icon, and drop window width trailing inset math. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Sidebar toggle SVG fills were missing from XCUITest/screencapture PNGs while accessibility frames still passed. Rasterize Phosphor icons during parity capture and mirror the sidebar glyph like web. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Deferring icon rasterization to onAppear left a clear placeholder in mac-title-bar PNGs because XCUITest snapshots the window immediately. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
macOS parity capture: XCUITest finds the sidebar toggle and asserts content-track layout, but full-window PNGs had zero dark pixels in the toggle region (flat top-right band). That indicates an app rendering/compositing issue, not capture cropping alone.
Approach
drawingGroupand mount chrome in the main column (web header shape).TitleBarSidebarToggle(NSButton) when SwiftUI controls did not appear in window bitmaps.parity-toggle-bounds.jsonattachment) and probe that rectangle when validatingmac-title-bar.png.CI evidence (not green)
minX=859, maxX=883, minY=14, maxY=38at 1280pt width.xcui-windowcrop: 0 dark pixels after SwiftUI, SF Symbol, bordered debug chrome, and AppKit button attempts.Blocker
Trailing title-bar controls do not composite into XCUITest/screencapture window PNGs while accessibility reports them on the content track. Needs macOS-local view/layer debugging (hosting view clip, layer order, or screenshot vs accessibility mismatch).
VERDICT: FAIL (macos-capture title bar validation)