auth: request scopes needed by in-flight server-side OAuth changes | DAL-971 DAL-972 DAL-959 DAL-973 - #714
Draft
srosenthal-dd wants to merge 1 commit into
Conversation
Adds metrics_metadata_write, synthetics_default_settings_write, and ccm_budget_write to default_scopes(). All three are released Standard-tier permissions whose routes are gaining OAuth support server-side; without the scope the token pup obtains cannot satisfy the route's permission check. Documents org_group_read/org_group_write as opt-in --extra-scopes scopes (Admin tier, so not default-requested). Deliberately omits deployment_gates_* (still Development: true, so not public scopes) and cd_visibility_read (it OR-satisfies the deployment-gates write routes, so it must not land in the read-only scope set). DAL-971 DAL-972 DAL-959 DAL-973
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Expand support for OAuth, in particular for the pup CLI and other AI-agent/programmatic clients. OAuth is now a general-purpose auth method, and is preferred over API+App Keys because it's always scoped and credentials automatically expire.
Changes
Add scopes needed by in-flight server-side OAuth PRs, so pup's login tokens carry the required permission once each route lands:
metrics_metadata_write→ dogweb#1868synthetics_default_settings_write→ dd-source#48398ccm_budget_write→ dd-source#48392Also documents
org_group_read/org_group_writeas opt-in--extra-scopesscopes, paired with dd-source#48387.Deliberately not changed
deployment_gates_read/write/evaluate— stillDevelopment: true, not valid OAuth scopes yet.cd_visibility_read— would let a read-only login mutate deployment gates via the OR-gating on those routes (see dd-source#48400). Left out pending a decision from ci-cd.Test plan