workflows: send OAuth bearer token for action connections | DAL-751 - #713
Draft
srosenthal-dd wants to merge 1 commit into
Draft
workflows: send OAuth bearer token for action connections | DAL-751#713srosenthal-dd wants to merge 1 commit into
srosenthal-dd wants to merge 1 commit into
Conversation
make_connection_api used make_api_no_auth!, which skips the bearer token unconditionally, so connections requests fell back to API-key auth even for OAuth logins. The action-connections API already accepts OAuth server-side, so switching to make_api! is all that was blocking client-side support. Also adds connections_read to read_only_scopes() (it was already a default scope) and documents connections_write as an opt-in --extra-scopes scope. DAL-751
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Expand support for OAuth, in particular for the pup CLI and other AI-agent/programmatic clients. OAuth is now a general-purpose auth method, and is preferred over API+App Keys because it's always scoped and credentials automatically expire.
Changes
Send the OAuth bearer token for action-connections requests.
make_connection_apiwas usingmake_api_no_auth!, which always sent API key auth even with a valid OAuth session; switched tomake_api!. The action-connections API already accepts OAuth server-side, so this was the only client-side blocker.Also adds
connections_readtoread_only_scopes()(it was already a default scope, just missing from the read-only subset) and documentsconnections_writeas an opt-in--extra-scopesscope.Deliberately not changed
connections_writeis not added todefault_scopes()— connection management is treated as sensitive and stays opt-in.Test plan