Skip to content

auth: request scopes needed by in-flight server-side OAuth changes | DAL-971 DAL-972 DAL-959 DAL-973 #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
srosenthal-dd wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Draft

auth: request scopes needed by in-flight server-side OAuth changes | DAL-971 DAL-972 DAL-959 DAL-973 #714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/auth/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ pub fn default_scopes() -> Vec<&'static str> {
"ci_visibility_read",
"code_coverage_read",
// Cloud Cost Management
"ccm_budget_write",
"cloud_cost_management_read",
"cloud_cost_management_write",
"dora_metrics_read",
Expand Down Expand Up @@ -200,6 +201,7 @@ pub fn default_scopes() -> Vec<&'static str> {
"logs_write_pipelines",
"saved_views_write",
// Metrics
"metrics_metadata_write",
"metrics_read",
// Monitors
"monitors_read",
Expand Down Expand Up @@ -248,6 +250,7 @@ pub fn default_scopes() -> Vec<&'static str> {
"status_pages_settings_read",
"status_pages_settings_write",
// Synthetics
"synthetics_default_settings_write",
"synthetics_read",
"synthetics_write",
"synthetics_private_location_read",
Expand Down Expand Up @@ -348,6 +351,10 @@ mod tests {
assert!(scopes.contains(&"saved_views_write"));
// APM trace metrics
assert!(scopes.contains(&"apm_generate_metrics"));
// Batch 3 additions
assert!(scopes.contains(&"synthetics_default_settings_write"));
assert!(scopes.contains(&"ccm_budget_write"));
assert!(scopes.contains(&"metrics_metadata_write"));
}

#[test]
Expand Down Expand Up @@ -398,6 +405,8 @@ mod tests {
assert!(!ro.contains(&"teams_manage"));
assert!(!ro.contains(&"monitors_write"));
assert!(!ro.contains(&"logs_write_pipelines"));
assert!(!ro.contains(&"ccm_budget_write"));
assert!(!ro.contains(&"synthetics_default_settings_write"));
}

#[test]
Expand Down
4 changes: 4 additions & 0 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2171,6 +2171,10 @@ enum Commands {
///
/// AUTHENTICATION:
/// Requires either OAuth2 authentication or API keys with org management permissions.
/// The policies/policy-overrides/policy-configs subcommands require the
/// org_group_read (read) and org_group_write (write) scopes, which are
/// not requested by default -- opt in with:
/// pup auth login --extra-scopes org_group_read,org_group_write
#[command(verbatim_doc_comment)]
Organizations {
#[command(subcommand)]
Expand Down