Repository navigation
Apply the internal limits to bulk events - #182
Merged
Merged
Conversation
CountlyBulk read its limits from properties that were never set, so the events it queued were never cut. add_user now copies the bulk user's settings as given, since the event limits do not apply to them.
CI report
Public API changes: Public API, No public API changeNo public API change. For a89f1fd, updated 2026-11-16 05:59 UTC. Each check's run page has its full log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Events added to
CountlyBulknow keep to itsmax_key_length,max_value_sizeandmax_segmentation_valueslimits (128, 256 and 100 by default), as events in the main SDK do.add_eventread the limits from properties that were never set, so bulk events were never cut. This dates back to e68bcdd, where the limits were added.add_userno longer runs the event limits over the bulk user's settings (device_id, location,require_consent, the user's own limits) and copies them as given, asadd_requestdoes since cbc6ac2. That call was inactive for the same reason, so bulk users behave as before.max_segmentation_valuesis now 100, the value the code uses.Tests in
test/tests_bulk_fixes.jscover the configured limits end to end through/i/bulk, the default limits, events of a bulk user, events from a cluster worker, and a bulk user that requires consent keeping its settings under low limits. The first four fail without the fix;npm testpasses locally (247 tests).#186 builds on this pull request.