Skip to content

Apply the internal limits to bulk events - #182

Merged
arifBurakDemiray merged 1 commit into
stagingfrom
bulk-limits
Nov 17, 2026
Merged

arifBurakDemiray merged 1 commit into
stagingfrom
bulk-limits

Conversation

@turtledreams

@turtledreams turtledreams commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Events added to CountlyBulk now keep to its max_key_length, max_value_size and max_segmentation_values limits (128, 256 and 100 by default), as events in the main SDK do.

  • add_event read the limits from properties that were never set, so bulk events were never cut. This dates back to e68bcdd, where the limits were added.
  • add_user no longer runs the event limits over the bulk user's settings (device_id, location, require_consent, the user's own limits) and copies them as given, as add_request does since cbc6ac2. That call was inactive for the same reason, so bulk users behave as before.
  • Events of a bulk user are cut with the user's limits first and then with the bulk instance's limits, so a per-user limit above the instance's is capped by it. Events that cluster workers hand to the main process are cut there with its limits.
  • The documented default of max_segmentation_values is now 100, the value the code uses.

Tests in test/tests_bulk_fixes.js cover the configured limits end to end through /i/bulk, the default limits, events of a bulk user, events from a cluster worker, and a bulk user that requires consent keeping its settings under low limits. The first four fail without the fix; npm test passes locally (247 tests).

#186 builds on this pull request.

CountlyBulk read its limits from properties that were never set, so the
events it queued were never cut. add_user now copies the bulk user's
settings as given, since the event limits do not apply to them.
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

CI report

Check Result Summary
CodeQL ✅ passed
Node.js CI ✅ passed
Public API changelog ✅ passed
Public API changes ✅ passed Public API: No public API change
Public API changes: Public API, No public API change

No public API change.

For a89f1fd, updated 2026-11-16 05:59 UTC. Each check's run page has its full log.

@arifBurakDemiray
arifBurakDemiray merged commit 537471e into staging Nov 17, 2026
21 checks passed
@arifBurakDemiray
arifBurakDemiray deleted the bulk-limits branch November 17, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants