Repository navigation
fix: apply configured limits in bulk mode - #181
Closed
pcbeingused333 wants to merge 1 commit into
Closed
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
Contributor
|
Thank you for finding this and for the clear description, @pcbeingused333! We carried the change over to #182, which targets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bulk event and user configuration truncation reads limits from instance properties that are never initialized. The normalized limits are stored in
conf, so both configured and default limits are silently ignored.Use the normalized configuration in
add_eventandadd_user, matching where the constructor stores these limits. Regression tests cover event names, segmentation keys, values and counts, default event limits, and bulk user configuration limits.Testing
node_modules/.bin/mocha --timeout 10000 test/tests_bulk_limits.js --exit: three failures before the fix, three passes after it.node_modules/.bin/mocha --timeout 180000 test/tests_bulk_limits.js test/tests_bulk_fixes.js --exit --allow-uncaught: 12 passing.node_modules/.bin/eslint lib/countly-bulk.js test/tests_bulk_limits.js: passes.This change was prepared with assistance from OpenAI Codex.