Skip to content

Let bulk users use the limits set for the bulk instance - #186

Merged
arifBurakDemiray merged 2 commits into
stagingfrom
bulk-user-limits
Nov 17, 2026
Merged

arifBurakDemiray merged 2 commits into
stagingfrom
bulk-user-limits

Conversation

@turtledreams

@turtledreams turtledreams commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Builds on #182: the first commit is the one from #182, so #182 merges first.

A bulk user took its limits only from the settings passed to add_user and otherwise used the defaults, so the max_* limits set for CountlyBulk never reached the bulk user's own methods: user details, custom properties, views, conversions and traces. A bulk user now falls back to the limits of its CountlyBulk instance, and a limit set for the user still takes precedence.

  • The limits have come from the user's settings only since e68bcdd, where they were added.
  • Without limits set for CountlyBulk nothing changes, since its defaults are the same as the bulk user's.
  • The documented defaults of the bulk user's max_* options now name this fallback.

Tests in test/tests_bulk_fixes.js: the profile, custom properties, views and traces of a bulk user keep to the limits set for CountlyBulk (fails without the fix), and a limit set for the user takes precedence. npm test passes locally (249 tests).

CountlyBulk read its limits from properties that were never set, so the
events it queued were never cut. add_user now copies the bulk user's
settings as given, since the event limits do not apply to them.
A bulk user took its limits only from its own settings and otherwise used
the defaults, so the limits set for CountlyBulk did not reach user
details, custom properties, views, conversions and traces. A limit set
for the user still takes precedence.
@turtledreams
turtledreams changed the base branch from bulk-limits to staging November 16, 2026 08:19
@turtledreams turtledreams reopened this Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

CI report

Check Result Summary
CodeQL ✅ passed
Node.js CI ✅ passed
Public API changelog ✅ passed
Public API changes ✅ passed Public API: No public API change
Public API changes: Public API, No public API change

No public API change.

For 135d896, updated 2026-11-16 08:24 UTC. Each check's run page has its full log.

@arifBurakDemiray
arifBurakDemiray merged commit 8ffbc7d into staging Nov 17, 2026
23 checks passed
@arifBurakDemiray
arifBurakDemiray deleted the bulk-user-limits branch November 17, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants