Skip to content

docs(AGENTS): keep Figma guidance minimal#93

Closed
seonghobae with Copilot wants to merge 5 commits into
masterfrom
copilot/task-295022177-102973287-331a969f-e64a-48ce-8374-cf9791c16331
Closed

docs(AGENTS): keep Figma guidance minimal#93
seonghobae with Copilot wants to merge 5 commits into
masterfrom
copilot/task-295022177-102973287-331a969f-e64a-48ce-8374-cf9791c16331

Conversation

Copilot AI commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Ponytail reduction of the original Figma/design-system docs.

Current scope:

  • adds one repo-specific AGENTS.md guardrail: aFIPC has no frontend, route tree, Figma file, or visual surface, so agents must not create UI code or visual artifacts without a real product surface
  • keeps the useful naming rule: future Figma work must not be called a "design system" unless it has real reusable foundations, tokens, components, states, accessibility guidance, and code mapping
  • removes the speculative product-design handoff doc, wireframe, and long generic KRDS checklist

No R behavior, calibration/linking logic, workflows, tests, or frontend code changed.

Copilot AI changed the title [Figma] 디자인 시스템 명칭 사용을 위한 최소 구성요소 및 작업 기준 정의 docs(AGENTS): add Figma design system minimum criteria Jul 2, 2026
Copilot AI requested a review from seonghobae July 2, 2026 07:13
@seonghobae seonghobae marked this pull request as ready for review July 2, 2026 07:37
Copilot AI review requested due to automatic review settings July 2, 2026 07:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

Adds KRDS-aligned minimum criteria for when a Figma file can be labeled a “design system,” clarifying required foundations, token structure, component/pattern expectations, accessibility, documentation, and dev mapping.

Changes:

  • Documents 10 minimum criteria for using the “design system” label in Figma deliverables.
  • Adds guidance on when to downgrade the label (UI Kit / Library / Draft) and an explicit Definition of Done checklist.
  • Includes supporting KRDS/Figma references via footnotes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread AGENTS.md Outdated
Comment thread AGENTS.md Outdated
Comment thread AGENTS.md Outdated

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed PR #93 against the current aFIPC scope. This is documentation-only, addresses the prior outdated markdown review comments, preserves the no-unrequested-frontend rule, and does not touch fixed-parameter calibration code, literature evidence, true-parameter tests, Hessian/vcov, or secondordertest behavior.

@seonghobae seonghobae changed the title docs(AGENTS): add Figma design system minimum criteria docs(AGENTS): keep Figma guidance minimal Jul 9, 2026
@seonghobae seonghobae disabled auto-merge July 9, 2026 07:44
@seonghobae seonghobae enabled auto-merge (squash) July 9, 2026 07:44

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head 07dc8dc. The PR is documentation-only, keeps the aFIPC Product Design/Figma guidance minimal for a repo with no frontend or visual surface, and does not touch Fixed Parameter Item Calibration code, true-parameter tests, Hessian/vcov, or secondordertest behavior.

@seonghobae

Copy link
Copy Markdown
Collaborator

Queue-head recheck for current head 07dc8dcafcf4db35dd210c83411861dec62473dc:

  • docs(AGENTS): keep Figma guidance minimal #93 is still the lowest open aFIPC PR and auto-merge is enabled with squash.
  • The diff remains documentation-only: AGENTS.md only, 9 inserted lines.
  • Local validation against current origin/master passed:
    • git diff --check origin/master...HEAD
    • npx --yes markdownlint-cli2@0.18.1 README.md AGENTS.md ARCHITECTURE.md CLAUDE.md CONTRIBUTING.md ".github/**/*.md" "docs/**/*.md" -> 14 files, 0 errors
  • This does not touch Fixed Parameter Item Calibration code, literature/evidence, true-parameter tests, SE=TRUE Hessian/vcov, or secondordertest behavior.
  • Current GitHub gate state is still external/queue-bound: required check, quality, and secret-and-workflow-audit checks are pending, and the PR remains REVIEW_REQUIRED under the org ruleset.

auto-merge was automatically disabled July 9, 2026 10:56

Pull request was converted to draft

@seonghobae seonghobae marked this pull request as ready for review July 9, 2026 10:57
@seonghobae seonghobae closed this Jul 9, 2026
@seonghobae seonghobae reopened this Jul 9, 2026
@seonghobae seonghobae enabled auto-merge (squash) July 9, 2026 11:07
@seonghobae

Copy link
Copy Markdown
Collaborator

Closing this as superseded by #117, not as a workaround around checks. #93 only changes AGENTS.md with the minimal Product Design/Figma guardrail; #117 contains the same guardrail verbatim and adds the CWL governance block on top. Keeping #117 as the successor avoids duplicate queued check/review cycles while preserving the full #93 content. No R behavior, workflows, tests, or calibration logic are being dropped.

@seonghobae seonghobae closed this Jul 9, 2026
auto-merge was automatically disabled July 9, 2026 12:56

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants