Repository navigation
fix(mobile): drop the frosted header band and inset Back before iOS 26 - #2466
Merged
Merged
Conversation
Before iOS 26 the chat header used UIKit's systemChromeMaterial blur, a frosted band with a hard bottom edge, and UIKit's back button sat 8pt from the screen edge. Keep the bar transparent there, draw the same top fade as Android, and use the opaque round Back, title chip and computer button islands as custom bar items so Back gets the standard margin. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q2peBu5V6uF4Woh6wjh7Sj
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
# Conflicts: # apps/mobile/src/ui/chat/conversation-screen.tsx
DoodleBears
marked this pull request as ready for review
October 21, 2026 14:02
DoodleBears
added a commit
that referenced
this pull request
Oct 21, 2026
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
Device check on iPhone XS Max, iOS 18.1.1: PASS, with one visual nitTested on main 2b82975 (Release, app and Host), in the Xiaoce DM scrolled to mid-history, light and dark.
Nit, clearer in dark: the islands are very translucent and the fade is weakest at the chip's band (about y 90–120 pt). So message text behind the "Xiaoce" chip stays legible and competes with the title. A slightly stronger island fill, or an earlier and steeper top fade, would fix it.
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Requested by Vain · project thread
Why the change
On iOS 18 (iPhone XS Max) the chat header shows a frosted band with a hard bottom edge, and Back hugs the screen edge. iOS 26/27 don't show either. Cause: before iOS 26 the chat set
headerBlurEffect: 'systemChromeMaterial'(UIKit's bar material, since there's no Liquid Glass), and UIKit's back button sits 8pt from the edge.Refs #2344
Special things to note
vitestfor apps/mobile (1031 tests pass after merging main),tsc --noEmit,oxlint,oxfmt --check, source policy; CI green. New tests cover: iOS 26 keeps native Back and no drawn top fade; before iOS 26 no blur effect, native back hidden, round Back item present, top fade height = header +edgeFade.reach. iOS 27 Simulator regression check passes (shot below).Change outline
Before iOS 26:
EdgeFadeas Android (solid across the status bar, curve clearsedgeFade.reachbelow the header).headerGlassFill), ascustombar items, so Back gets the bar's standard leading margin. NewheaderIslandsflag inheader-kind.ts(Android, or iOS < 26).iOS 27 regression (unchanged native glass header):
iOS 18 light/dark: follow-up from the XS Max batch run.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Q2peBu5V6uF4Woh6wjh7Sj