Repository navigation
fix(mobile): opaque header islands and app-colour chip text before iOS 26 - #2513
Merged
Merged
Conversation
On the XS Max (iOS 18) the frosted header islands let message text show through the title chip and compete with it, worse in dark. There is no blur behind them before iOS 26, so give them the opaque raised fill. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q2peBu5V6uF4Woh6wjh7Sj
The XS Max shots showed a black Bot name on the dark chip: the system label colour follows the system appearance, while our own chip fill follows the app's. Use label only with the iOS 26 glass header. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q2peBu5V6uF4Woh6wjh7Sj
DoodleBears
changed the title
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 22 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Vain · project thread
Why the change
Follow-up to #2466. In the iOS 18 shots from the XS Max, the header's Back, title chip and computer button are too transparent, so message text behind the chat title stays readable and competes with it. In dark mode the Bot's name is also drawn in black on the dark chip.
Refs #2466
Special things to note
labelcolour. Android keeps its frosted fill andfgtext. Revert is one or two commits.vitest(1036 pass),tsc --noEmit,oxlint,oxfmt. The device recheck is queued for the next iOS batch.Change outline
headerGlassFill's non-glass fill uses the opaqueraised.fillon iOS instead offrosted(raised.fill), which is translucent with no blur behind it before iOS 26.barLabelStyle(the systemlabelcolour) applies only with the glass header. On our own opaque chip, the text uses the theme'sfg, so it follows the app's appearance and not the system's.Before (main 2b82975, XS Max iOS 18.1.1, dark): the chip is see-through and the name is black.
After: pending the XS Max batch (light/dark).
🤖 Generated with Claude Code
https://claude.ai/code/session_01Q2peBu5V6uF4Woh6wjh7Sj