Repository navigation
Unify mobile drawer headers with iOS glass titles - #2172
Conversation
Issue: #2171 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Batch23 completed and shared Simulator window released. No Prod or merge.
Task |
Issue: #2171 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9
|
Final evidence-only head |
…cal names (#2175) * feat(mobile): separate computer and cloud drawer tabs Issue: #2174 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9 * docs: attach native drawer tabs screenshots Issue: #2174 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9 * fix(mobile): make drawer additions category-specific (#2174) Agent claim: #2174 (comment) * fix(mobile): keep contextual add directly below drawer tabs (#2174) * fix(mobile): retain native tab bounds for accessibility (#2174) * fix(mobile): keep drawer escape container separate from tabs (#2174) * fix(mobile): expose iOS segmented tabs as selected buttons (#2174) * feat(mobile): compact connection rows and pin drawer footer (#2174) Allow local names during pairing and verified cloud import, with cloud rename preserving trusted scope and sessions. Agent claim: #2174 (comment) * fix(mobile): keep drawer footer inside panel (#2174) * docs(mobile): capture compact drawer and naming evidence (#2174)
Header issue #2171 | Remaining acceptance #2186
Compact drawer issue #2174 | Agent claim
Why the change
Unify generic Sheet titles and make the workspace drawer easier to scan with separate Computer/Cloud actions, compact named connections and a fixed Notifications footer.
Special things to note
config.name; Host identity, organization names, credentials and trusted discovery remain unchanged. Organization creation stays in cloud service management.dc15ffd3a; final native layout uses integrated1376b50b1. Naming save/restart/restore was verified atf2d0f4af3with identical naming code. Android, physical phone, VoiceOver, signed-in org/guest rows and real named-computer pairing remain unverified. The previously observed Pair-modal → cloud-services drawer-overlay issue remains open; no full navigation acceptance is claimed. Task:codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9.Change outline
Default text uses at most two lines per connection; accessibility text can wrap. Tabs do not change a Host or membership. Swipe/backdrop/Android Back/accessibility escape replace the redundant X; iOS tabs use selected-button semantics to avoid a verified native accessibility target-grouping failure. A duplicate footer in the backdrop was caught during native review and removed before final capture.
Native drawer comparisons — 402 × 874, English
Before is the preceding title/X + mixed Add iteration (
59fc97fd7), not the PR base. Both captures use the same empty Computer directory and signed-out UAT cloud configuration. Theme/viewport/locale match; the small exposed underlying route differs, so compare the drawer itself. Original PR-base evidence is retained in the older evidence directory.Computers — light, before / after
Cloud — light, before / after
Computers — dark, before / after
Cloud — dark, before / after
Connect with a local name
Computer pairing adds an optional name before scanning/pasting. The old pairing entry is the before state; native input was exercised without redeeming a pairing. Cloud renaming was saved, survived a cold restart, then the exact original name was restored and read back. These naming screenshots use
f2d0f4af3; the final correction only removed the duplicated backdrop footer.Maximum text — independent list scroll
The middle list exposes the address after a swipe while Notifications remains at the same position. This checks reachability, not a full VoiceOver or accessibility acceptance.
Full source-bound screenshots, checks and limits. Shared Simulator/Metro released, original cloud name and display settings restored. The recorded native run made no login, invitation acceptance, Host or Prod changes. Integration is now authorized; outstanding acceptance is tracked in #2186.
Generic Sheet header retained from #2171
Workspace title/X is superseded by tabs. Generic bottom Sheet retains the left-aligned title, optional icon and independent close action; iOS uses glass with opaque fallback and Android a plain title. Settings SheetStack remains outside this slice.
Header evidence was captured at runtime
4185d28a3; final #2172 head4c6acb7epassed CI39117869759. Historical screenshots are not a fresh native run of the integration.