Repository navigation
feat(mobile): mix Computer and Cloud conversations (#2179) - #2185
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Issue: #2179 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9
Issue: #2179 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9
Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9
Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9
Slice #2179 — UAT Simulator acceptanceFinal head:
Limits: Android/physical-device/VoiceOver/Human QA remain unverified. Maximum Dynamic Type truncates names substantially. An offline Computer's roster returns after reconnect on a cold launch; its draft survives. Complete Cloud recency/read/pin behavior remains #2181. Local exact-head HTML explainer is generated, but not published as a reviewer-accessible artifact. PR remains Draft/open. UAT only; no Prod change, merge or later-slice implementation. Existing drawer-stack merge prerequisites remain. Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9 |
Issue: #2179 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9
StandardsNo blocking documented-standard violations or merge-blocking smells found at SpecNo actionable findings within #2179. Source/account/channel remain bound through navigation and authorized operations; temporary directory reads restore organization scope. Offline Computer sending is disabled; drafts restore independently of transport; reconnect does not invoke send. Existing explicit retry paths preserve operation identity. Independent Spec reviewer: 64 focused tests passed. Primary review run: mobile typecheck and 71 focused tests passed. Standards reviewer performed source review only. Prior UAT source Review totals: Standards 0 actionable findings; Spec 0 actionable findings. Merge remains conditional on final-head CI. No Prod changes. Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9 |
Slice #2179 · Claim · Spec #2178 · Milestone v2.0
Why the change
Mobile users can open their paired Computer conversations and authenticated Cloud channels from one list while each message stays with its original service and identity.
Special things to note
9e7399330was integrated ine65bd3e01with both sets of translation keys preserved. This PR implements only Mobile: mixed Computer and Cloud conversations with source-correct sending #2179; no Web/Desktop, read/pin authority or Bot wake changes. UAT only. The Human authorized merge after this correctness review passes.Change outline
UAT validation
Tested source / integrated QA:
d9155abe412dbdf4445394744f54d0e1f8743c4e. Evidence-only head:0e9de978867db92b9f22738796a67f63f6f5eabc. Reviewed main-integration head:e65bd3e01b911622674135e317b927dc2f13aac8(71 focused tests and mobile typecheck passed; original screenshots are from the tested source above, not a new native run). Existing SDK 58 native build494a20f1e; JS-only reload, no native build/deploy.The initial cold-start failure was retained and fixed: an empty organization sentinel could invalidate the saved session and block Home. New source passed fresh CI and runtime recheck. A development-tool floating button initially intercepted a keyboard Send tap; moving it through the UI restored the actual Send interaction. Neither initial attempt is counted as a successful send.
Mixed list — iOS Simulator, 402 × 874, light
Before: Computer conversations only; same fixture accounts and viewport.
After: Computer and Cloud rows with source icons and source/organization filters.
Computer channel — same viewport
Before/after header comparison; the after state also contains the uniquely marked UAT message sent during verification.
Offline and restart — actual UAT states
Left: Computer route offline, unsent draft retained and Send unavailable. Right: after cold restart and reconnect, the same draft remains unsent.
Watch offline Computer → Cloud send (4×) · Watch restored draft after restart
Dark mode and larger text
Full evidence and proof limits includes Cloud committed-message screenshots, actual incoming Bot reply, and default/intermediate/maximum text in both themes. Android/physical/VoiceOver/Human checks remain unverified. No #2180–2182 implementation in this PR.
Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9