Repository navigation
feat(mobile): compact workspace drawer with contextual actions and local names - #2175
Merged
Merged
Conversation
Issue: #2174 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Issue: #2174 Agent-Task: codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9
Allow local names during pairing and verified cloud import, with cloud rename preserving trusted scope and sessions. Agent claim: #2174 (comment)
DoodleBears
marked this pull request as ready for review
October 18, 2026 10:05
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2174 | Agent claim
Why the change
Make the mobile drawer easier to scan with separate Computer/Cloud actions, compact named connections and Notifications fixed at the bottom.
Special things to note
config.name; Host identity, organization names, credentials and trusted discovery remain unchanged. Organization creation stays in cloud service management.dc15ffd3a; final native layout uses integrated1376b50b1. Naming save/restart/restore was verified atf2d0f4af3with identical naming code. Android, physical phone, VoiceOver, signed-in org/guest rows and real named-computer pairing remain unverified. The previously observed Pair-modal → cloud-services drawer-overlay issue remains open; no full navigation acceptance is claimed. Task:codex/local/01a148ae-ec7f-74b2-8157-961411ce54c9.Change outline
Default text uses at most two lines per connection; accessibility text can wrap. Tabs do not change a Host or membership. Swipe/backdrop/Android Back/accessibility escape replace the redundant X; iOS tabs use selected-button semantics to avoid a verified native accessibility target-grouping failure. A duplicate footer in the backdrop was caught during native review and removed before final capture.
Native drawer comparisons — 402 × 874, English
Before is the preceding title/X + mixed Add iteration (
59fc97fd7), not the PR base. Both captures use the same empty Computer directory and signed-out UAT cloud configuration. Theme/viewport/locale match; the small exposed underlying route differs, so compare the drawer itself. Original PR-base evidence is retained in the older evidence directory.Computers — light, before / after
Cloud — light, before / after
Computers — dark, before / after
Cloud — dark, before / after
Connect with a local name
Computer pairing adds an optional name before scanning/pasting. The old pairing entry is the before state; native input was exercised without redeeming a pairing. Cloud renaming was saved, survived a cold restart, then the exact original name was restored and read back. These naming screenshots use
f2d0f4af3; the final correction only removed the duplicated backdrop footer.Maximum text — independent list scroll
The middle list exposes the address after a swipe while Notifications remains at the same position. This checks reachability, not a full VoiceOver or accessibility acceptance.
Full source-bound screenshots, checks and limits. Shared Simulator/Metro released, original cloud name and display settings restored. No login, invitation acceptance, Host write, Prod change or merge.