Skip to content

fix: preserve custom dataset payload profile #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesgao-jpg wants to merge 1 commit into
base: LargeTopk
Choose a base branch
from
Open

fix: preserve custom dataset payload profile #862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,22 @@ def test_performance_case_config_applies_top_level_payload_without_mutating_cust
assert custom_case == {}


def test_custom_performance_case_config_applies_top_level_payload():
case_config = CaseConfig(
case_id=CaseType.PerformanceCustomDataset,
custom_case={
"name": "custom",
"description": "",
"load_timeout": 1,
"optimize_timeout": 1,
"dataset_config": {"size": 1, "dim": 1},
},
payload_profile=PayloadProfile.VECTOR,
)

assert case_config.case.payload_profile == PayloadProfile.VECTOR


def test_performance_case_config_payload_round_trip_and_hash_identity():
ids_only = CaseConfig(
case_id=CaseType.Performance768D100M,
Expand Down
1 change: 1 addition & 0 deletions vectordb_bench/backend/cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,7 @@ def __init__(
dataset=DatasetManager(data=dataset),
use_filter=use_filter,
label_percentage=label_percentage,
**kwargs,
)

@property
Expand Down