Skip to content

fix: preserve custom dataset payload profile - #862

Open
jamesgao-jpg wants to merge 1 commit into
LargeTopkfrom
fix/pr834-custom-payload-forwarding
Open

fix: preserve custom dataset payload profile#862
jamesgao-jpg wants to merge 1 commit into
LargeTopkfrom
fix/pr834-custom-payload-forwarding

Conversation

@jamesgao-jpg

Copy link
Copy Markdown
Collaborator

Summary

  • Forward custom performance-case keyword arguments to PerformanceCase, preserving the selected payload profile.
  • Add a regression test covering a custom dataset with payload_profile=vector.

Scope

PR #834 introduces top-level payload profiles for performance cases; this focused follow-up fixes the custom-dataset constructor path identified during review.

The related audit covered registered PerformanceCase constructors affected by that new argument. No other forwarding gaps were found: standard cases inherit the base initializer, while the other custom constructors explicitly forward **kwargs.

Testing

  • tests/test_models.py::test_custom_performance_case_config_applies_top_level_payload (red before the fix, green after)
  • tests/test_models.py::test_performance_case_config_applies_top_level_payload_without_mutating_custom_case

Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jamesgao-jpg
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants