Skip to content

Python: prefilter directly controlled SSA uses #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yoff wants to merge 1 commit into from
+7 −2
Draft

Python: prefilter directly controlled SSA uses #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions python/ql/src/semmle/python/functions/ModificationOfParameterWithDefaultCustomizations.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,17 +143,22 @@ module ModificationOfParameterWithDefault {
}
}

private predicate directlyControlledUse(
DataFlow::GuardNode guard, Cfg::NameNode use, boolean branch
) {
guard != use and guard.controlsBlock(use.getBasicBlock(), branch)
}

/** Holds if `barrier` is a use guarded by a direct truthiness check on `branch`. */
private predicate directGuardedUse(DataFlow::ExprNode barrier, boolean branch) {
exists(
DataFlow::GuardNode guard, SsaImpl::EssaDefinition def, Cfg::NameNode checked,
Cfg::NameNode use
|
checked = guard and
directlyControlledUse(guard, use, branch) and
SsaImpl::AdjacentUses::useOfDef(def, checked) and
SsaImpl::AdjacentUses::useOfDef(def, use) and
checked != use and
guard.controlsBlock(use.getBasicBlock(), branch) and
barrier.asCfgNode() = use
)
}
Expand Down
Loading